Add CI testing for pypsa2smspp package integration#53
Open
Conversation
Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>
Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>
Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add execution of pypsa2smspp test to the CI
Add CI testing for pypsa2smspp package integration
Feb 18, 2026
davide-f
reviewed
Feb 18, 2026
.github/workflows/test.yml
Outdated
Comment on lines
65
to
66
| - "3.13" | ||
| - "3.12" |
Contributor
Author
There was a problem hiding this comment.
Updated to Python 3.13 only in commit cb80a74.
.github/workflows/test.yml
Outdated
Comment on lines
90
to
92
| - name: Test pypsa2smspp integration | ||
| run: | | ||
| pytest test/test_pypsa2smspp.py -v |
Member
There was a problem hiding this comment.
I want to execute pytest on pypsa2smspp package using the pysmspp package being tested
Contributor
Author
There was a problem hiding this comment.
Updated in commit cb80a74. The CI now clones the pypsa2smspp repository and runs its full test suite, which will use the pysmspp package being tested from the current PR.
- Limit Python version to 3.13 only as requested - Clone pypsa2smspp repository and run its full test suite - Remove custom integration tests in favor of pypsa2smspp's own tests - This ensures pypsa2smspp tests use the pysmspp package being tested Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>
Contributor
Author
- Changed test_pypsa2smspp job to depend on test_with_smspp instead of test - Added -W ignore::FutureWarning flag to pytest command to suppress FutureWarnings - This addresses pypsa2smspp tests failing due to FutureWarnings being treated as errors Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>
Contributor
Author
Both changes completed in commit 20e58a4:
|
davide-f
reviewed
Feb 18, 2026
.github/workflows/test.yml
Outdated
Comment on lines
157
to
166
| - name: Install pypsa2smspp with tests | ||
| run: | | ||
| git clone https://github.com/SPSUnipi/pypsa2smspp.git | ||
| cd pypsa2smspp | ||
| pip install -e .[dev] | ||
|
|
||
| - name: Test pypsa2smspp package | ||
| run: | | ||
| cd pypsa2smspp | ||
| pytest -v -W ignore::FutureWarning |
Member
There was a problem hiding this comment.
Move these two steps as steps of test_pypsa2smspp and ignore all warnings
Contributor
Author
There was a problem hiding this comment.
Completed in commit 8d52bc9:
- Moved the two steps as steps of test_with_smspp job
- Changed pytest to use
-W ignoreto ignore all warnings
- Removed separate test_pypsa2smspp job - Added pypsa2smspp installation and testing as steps in test_with_smspp job - Changed pytest to ignore all warnings with -W ignore (instead of just FutureWarning) - This simplifies the CI workflow by consolidating pypsa2smspp tests with SMSpp tests Co-authored-by: davide-f <67809479+davide-f@users.noreply.github.com>
davide-f
force-pushed
the
copilot/add-pypsa2smspp-test-ci
branch
from
ea634cf to
8d52bc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CI testing for the pypsa2smspp package to ensure compatibility with pySMSpp by running pypsa2smspp's full test suite within the existing SMSpp test job.
Changes
.github/workflows/test.yml: Modified thetest_with_smsppjob to include pypsa2smspp testing:-W ignoreflag to suppress all warnings during pypsa2smspp tests.gitignore: Addedpypsa2smspp/directory to prevent accidentally committing the cloned repositoryRationale
The CI job ensures that pypsa2smspp (which depends on pySMSpp) continues to work correctly with the version of pySMSpp being developed. By running pypsa2smspp's own test suite with the pySMSpp under test within the SMSpp testing job, we can catch any breaking changes early while keeping the workflow streamlined.
Testing
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.