feat(BOR-455): add macOS mount POC scaffold#16
feat(BOR-455): add macOS mount POC scaffold#16bdclaw2026 wants to merge 2 commits intoSTRRL:mainfrom
Conversation
|
@claude please review this PR |
|
@codex please review this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c423255bbd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| public func read(path: String) throws -> Data { | ||
| guard let data = objects[path] else { |
There was a problem hiding this comment.
The mock store reads objects using the raw path as a dictionary key, so absolute file-system paths like /docs/readme.txt will miss seeded keys such as docs/readme.txt and incorrectly throw 404s. Since this bridge is intended for future FS callback wiring, any callback that passes POSIX-style absolute paths will fail read operations (and similarly write inconsistent keys), so path normalization should happen before lookup/write.
Useful? React with 👍 / 👎.
Absolute filesystem paths like /docs/readme.txt were failing to match seeded keys like docs/readme.txt, causing incorrect 404s. Strip the leading slash before using path as a dictionary key in both read and write. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@claude please review this PR |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2904f58c1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| public func list(prefix: String) throws -> [ObjectEntry] { | ||
| let normalized = prefix == "/" ? "" : prefix |
There was a problem hiding this comment.
read and write both strip a leading /, but list only special-cases the exact root string /; if FSKit or another caller passes absolute prefixes like /docs/, list will return no entries even when matching keys exist, making mounted directories appear empty despite readable files. This inconsistency in path normalization is introduced here and will surface as soon as non-root listings use absolute paths.
Useful? React with 👍 / 👎.
1 participant
Summary
poc/macos-mountSwift package scaffold for mount pipeline explorationValidation
cd poc/macos-mount && swift run MountPOCpassesTicket
Status