Feat/ci release #23
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "permissions": { | ||
| "allow": [ | ||
| "Bash(gh repo view:*)", | ||
| "Bash(gh release list:*)", | ||
| "Bash(gh release view:*)", | ||
| "WebFetch(domain:raw.githubusercontent.com)", | ||
| "WebFetch(domain:github.com)" | ||
| ], | ||
| "deny": [], | ||
| "ask": [] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -e | ||
|
|
||
| HOMEBREW_TAP_REPO="STRRL/homebrew-collective" | ||
| CASK_NAME="transcube" | ||
| TEMP_DIR=$(mktemp -d) | ||
|
|
||
| cleanup() { | ||
| rm -rf "$TEMP_DIR" | ||
| } | ||
| trap cleanup EXIT | ||
|
|
||
| echo "Updating Homebrew cask for $CASK_NAME..." | ||
| echo "" | ||
|
|
||
| if [[ $# -eq 1 ]]; then | ||
| VERSION="$1" | ||
| else | ||
| GIT_TAG=$(git describe --tags --exact-match 2>/dev/null || echo "") | ||
| if [[ -z "$GIT_TAG" ]]; then | ||
| echo "Error: No version specified and no git tag found." | ||
| echo "Usage: $0 [VERSION]" | ||
| echo "Example: $0 0.1.10" | ||
| exit 1 | ||
| fi | ||
| VERSION="${GIT_TAG#v}" | ||
| fi | ||
|
|
||
| echo "Version: $VERSION" | ||
|
|
||
| DMG_NAME="TransCube-${VERSION}-macOS.dmg" | ||
| DMG_PATH="build/bin/$DMG_NAME" | ||
|
There was a problem hiding this comment. The script assumes it's run from the repository root. If called from a different directory, the DMG path resolution will fail. Make the path resolution robust: SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
PROJECT_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)"
DMG_PATH="$PROJECT_ROOT/build/bin/$DMG_NAME"Agent: 🧠 Logic |
||
|
|
||
| if [[ ! -f "$DMG_PATH" ]]; then | ||
| echo "Error: DMG file not found at $DMG_PATH" | ||
| echo "Please run build-and-release.sh first." | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Calculating SHA256 for $DMG_NAME..." | ||
| SHA256=$(shasum -a 256 "$DMG_PATH" | awk '{print $1}') | ||
|
There was a problem hiding this comment. Missing validation for SHA256 calculation. If shasum fails or the DMG is corrupted, the variable could be empty or invalid, leading to an invalid Homebrew cask. Add validation: SHA256=$(shasum -a 256 "$DMG_PATH" | awk '{print $1}')
if [[ -z "$SHA256" || ${#SHA256} -ne 64 ]]; then
echo "Error: Failed to calculate valid SHA256 hash"
exit 1
fiAgent: 🧠 Logic |
||
| echo "SHA256: $SHA256" | ||
| echo "" | ||
|
|
||
| echo "Cloning homebrew-collective repository..." | ||
| cd "$TEMP_DIR" | ||
| git clone "https://github.com/$HOMEBREW_TAP_REPO.git" tap | ||
| cd tap | ||
|
|
||
| CASK_FILE="Casks/${CASK_NAME}.rb" | ||
|
|
||
| if [[ ! -f "$CASK_FILE" ]]; then | ||
| echo "Error: Cask file not found at $CASK_FILE" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Updating $CASK_FILE..." | ||
|
|
||
| sed -i '' "s/version \".*\"/version \"$VERSION\"/" "$CASK_FILE" | ||
|
There was a problem hiding this comment. The Consider detecting the OS and adjusting the sed syntax: if [[ "$OSTYPE" == "darwin"* ]]; then
sed -i '' "s/version \".*\"/version \"$VERSION\"/" "$CASK_FILE"
sed -i '' "s/sha256 \".*\"/sha256 \"$SHA256\"/" "$CASK_FILE"
else
sed -i "s/version \".*\"/version \"$VERSION\"/" "$CASK_FILE"
sed -i "s/sha256 \".*\"/sha256 \"$SHA256\"/" "$CASK_FILE"
fiAgent: 🧠 Logic |
||
| sed -i '' "s/sha256 \".*\"/sha256 \"$SHA256\"/" "$CASK_FILE" | ||
|
|
||
| if git diff --quiet "$CASK_FILE"; then | ||
| echo "No changes detected in $CASK_FILE. Version might already be up to date." | ||
| exit 0 | ||
| fi | ||
|
|
||
| echo "" | ||
| echo "Changes to be committed:" | ||
| git diff "$CASK_FILE" | ||
| echo "" | ||
|
|
||
| git add "$CASK_FILE" | ||
| git commit -m "chore: update $CASK_NAME to $VERSION" | ||
|
|
||
| echo "Pushing to $HOMEBREW_TAP_REPO..." | ||
| git push origin master | ||
|
There was a problem hiding this comment. This push operation will fail without proper Git authentication (SSH keys or credential helper). Additionally, the hardcoded 'master' branch may not exist in the target repository (many have migrated to 'main'). Consider:
DEFAULT_BRANCH=$(git remote show origin | grep 'HEAD branch' | cut -d' ' -f5)
git push origin "$DEFAULT_BRANCH"
|
||
|
|
||
| echo "" | ||
| echo "Successfully updated Homebrew cask to version $VERSION" | ||
| echo "Users can now run: brew upgrade $CASK_NAME" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
set -econflicts with error handling in build-and-release.sh (lines 100-107). When any command fails, the script exits immediately, preventing proper error context from being passed back to the caller. This makes debugging difficult when something fails mid-execution (e.g., after cloning but before pushing).Consider either:
set -eand adding explicit error checking with descriptive messagesset -eEwith an error trap that logs context before exitingAgent: 🧠 Logic