Add autoplotter functionality#33
Merged
Merged
Conversation
Member
|
Anything that gets rid of the crazy parsing code we had for the velociraptor python library is a win for me. Totally happy, but don't have time to review (and I guess it's just copy and paste anyway :). |
JBorrow
approved these changes
May 28, 2026
Collaborator
Author
|
Perfect, thanks Josh! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to update the pipeline to use
swiftsimiofor reading the SOAP catalogues instead ofvelociraptor. This PR adds the autoplotting functionality fromvelociraptor, as it feels like a more natural fit here.@JBorrow, this is essentially a direct copy of the autoplotting code with a few minor modifications to support cosmo arrays. If you are not happy with this, then I can revert to depending on
velociraptorinstead.