Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings in the sable fork of element-call, newly built on npm. It works!
But! Right now sable-call is up to date with the absolute latest element-call version. Cinny and Sable before stuck to 16.3. There are some changes for sure that likely will cause some problems. The only one I notice so far is leaving calls doesn't get rid of the Cinny call bar on the bottom. In upstream Sable, it does.
Will try to fix this and see if there are other glaring problems that make downgrading back to 16.3 more worth it, or catching up to date more worth it. So: will keep this in draft for now.
See https://sable.melogale.space for the built version of this for testing!