feat: Implement an UI for commands#129
Open
Rosy-iso wants to merge 31 commits intoSableClient:devfrom
Open
Conversation
Member
|
Only issue I see is that there's no feedback for if the user has permission to change their pronouns/color/font in a space. Could disable those fields similar based on whether or not the user has permission (look at the code for the toggles and disable if the toggles are disabled, or similar). |
Contributor
Author
|
oh right, i forgot those could be disabled |
consistency? is this some king of Settings Menu Consistency PR 1.5??? /j
Contributor
Author
|
should be all good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an interface that replicates the behavior of the following commands:
The original commands will still remain and be usable however.
(In fact the interface calls the commands in the background, so the commands should not be changed.)
Type of change
Checklist: