change msgtype to m.emote to be more standard compliant#145
Merged
7w1 merged 2 commits intoSableClient:devfrom Mar 10, 2026
Merged
change msgtype to m.emote to be more standard compliant#1457w1 merged 2 commits intoSableClient:devfrom
7w1 merged 2 commits intoSableClient:devfrom
Conversation
7w1
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the msgtype from the custom
fyi.cisnt.headpatto the standardm.emotewhile still keeping the old rendering as fallback for older messages sent from sable.it will now generate events like the following:
{ "content": { "body": "pats @rye:itsrye.dev", "fyi.cisnt.headpat": true, "m.mentions": { "user_ids": [ "@rye:itsrye.dev" ] }, "msgtype": "m.emote" }, "event_id": "$OOWvyc9_vGKQvv9X_yI-L6Al7cZ88c45THHDP_BuaNg", "origin_server_ts": 1773156785613, "sender": "@client-testing:itsrye.dev", "type": "m.room.message", "unsigned": { "age": 19, "transaction_id": "m1773156785357.1" }, "room_id": "!OVi0VXH2pr4UWMdQvm:itsrye.dev" }while keeping the current behaviour and display
fixes #142
@tulir is welcome to look over it, as they raised the issue to me
Type of change
Checklist: