Fix mszip relying on exceptions #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
After the latest push, it peaks at ~5gb on the installer in |
Contributor
Author
|
Main thing still missing is that memory isn't being cleared properly, each block of compressedData still seems to be in memory? I'll need help with this, though. |
HeroponRikiBestest
changed the title
Contributor
Author
|
Disregard the above message. Better memory usage will come in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44 with some major changes. I don't know enough about mszip to know if this is 100% safe. I also assume you'd want me to make some changes on this.
This PR also drastically reduces the amount of memory needed to perform extraction, which is still a significant issue for mszip extraction.
The memory usage is still somewhat large, but I'm unsure how to properly clear memory beyond hoping C#/dotnet does it for me. If you can provide some input there, memory usage should be able to finally be reduced to a normal size.