Support Floodgate (Bedrock) left-click selling and add build artifact workflow#4
Open
iphonetips1 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
shouldSellcondition and using it for sell logic and cooldown checks.isBedrockPlayer(Player)which uses reflection to callorg.geysermc.floodgate.api.FloodgateApi#getInstanceandisFloodgatePlayer(UUID)so the plugin does not hard-depend on Floodgate at compile time and safely falls back if the API is absent or inaccessible.shouldSellboolean and consolidated the sell handling branch to use it instead of onlyAction.RIGHT_CLICK_BLOCK..github/workflows/build-artifact.ymlthat sets up Java (Temurin 21), caches Maven, runsmvn -B -DskipTests package, and uploadstarget/*.jar(excludingoriginal-*.jar) as theAxSellwands-jarartifact on pull requests or manual dispatches.Testing
mvn -DskipTests packagewhich explicitly skips test execution.workflow_dispatchevents.Codex Task