Clean up Codex-generated sellwand changes#7
Open
iphonetips1 wants to merge 1 commit into
Open
Conversation
- Use Map.merge() instead of manual containsKey/put pattern - Reuse existing sellwand variable instead of redundant map lookup - Fix history log computing uses-1 when uses is unlimited (-1) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Map.merge()instead of manual containsKey/put pattern for item countingsellwandvariable instead of redundantSellwands.getSellwands().get(type)lookup (also eliminates a potential NPE if the wand was unregistered mid-use)uses - 1when uses is unlimited (-1), which logged-2instead of-1Test plan
-1in history instead of-2🤖 Generated with Claude Code