Bring in Shopify modifications

[robforman]

No description provided.

[robforman]

Thanks for all the work on this, @peterjm.

Quick question- have you verified that it plays back without opening real connections? I ran tcpdump while running the specs and I see traffic when its supposed to be playing back from cassette. Is there a better way to test your changes?

rspec:

tcpdump (not supposed to see traffic):

[peterjm]

Interesting -- I hadn't used tcpdump; I'll take a look to see where the connection is coming from. Hopefully it's just an extra method that needs to be stubbed on the socket classes.

[peterjm]

Hmmmm... I wasn't able to reproduce the problem:

I'm a newbie to tcpdump, though.

And I agree that the way I'm checking for real http connections in the test isn't great. Maybe there's a system command we could try to use in the tests to detect real traffic?

[peterjm]

Also, I'd love to get this merged upstream, but there's a few caveats that I was going to address before sending a PR:

1. The use of prepend in tcr.rb means these changes are Ruby 2 only. We could avoid it by monkey-patching and using an alias method chain on initialize
2. The cassettes generated by these changes aren't backwards compatible
3. I didn't do anything with the to_io method, which you were previously stubbing out. I might have broken functionality for what you were previously doing
4. I was lazy about writing new specs for new functionality 😦

[robforman]

Yeah, tcpdump is playing hard to get. You need to add -l to flush the output buffer so grep can see it. You also need -A to show the ascii representation. Here are the flags I used:

I agree we should look for a deeper hook to watch for live traffic. I'll do some digging.

As far as your caveats:

1. I'm fine with Ruby 2.1- prepend is awesome. I'm already moving most of my projects over to Ruby 2.
2. Cassette migration is sort of a pain. Maybe we can add some backwards compatibility flag for reading old cassettes. It shouldn't be hard since the old ones are simpler. But I also try to design tests in a way where the cassettes can be deleted and re-run. Not a showstopper for me.
3. I saw that about to_io. Hard to say whether its broken yet. I found the issue with live traffic as I was testing this.
4. Now is your chance!

[peterjm]

1. Cool.
2. Detecting old cassettes would be pretty easy -- old cassettes serialize to an array, and new ones are a hash, so we could check whether the serialized object is an array and wrap it accordingly. We'd also need to not fail on close and connect when replaying old cassettes.
3. Thanks for the help with tcpdump -- I'll keep looking into the connection issue when I get a chance.
4. Hopefully on Friday or the weekend :)

[gmalette]

Any chance this will get picked up again?

[robforman]

The main issue was that the changes broke the network isolation somewhere along the way and it was sending traffic instead of stubbing it.