Skip to content

W-15904611 - Indicate inactive duplicate contact rules on contact merge page#7280

Open
salesforce-suyash-more wants to merge 6 commits intomainfrom
feature/256__W-15904611-tooltip-for-inactive-duplicate-rules
Open

W-15904611 - Indicate inactive duplicate contact rules on contact merge page#7280
salesforce-suyash-more wants to merge 6 commits intomainfrom
feature/256__W-15904611-tooltip-for-inactive-duplicate-rules

Conversation

@salesforce-suyash-more
Copy link
Contributor

@salesforce-suyash-more salesforce-suyash-more commented Feb 26, 2025

GUS : W-15904611

Critical Changes

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

@andrewyu-salesforce
Copy link
Contributor

andrewyu-salesforce commented Feb 28, 2025

@salesforce-suyash-more I did some UI testing and it seems like the old rule is still showing up. Please see the attached screenshot
Screenshot 2025-02-28 at 12 52 28 PM
Screenshot 2025-02-28 at 12 51 37 PM
Screenshot 2025-02-28 at 12 50 58 PM

@andrewyu-salesforce
Copy link
Contributor

andrewyu-salesforce commented Feb 28, 2025

The change should be modifing CON_ContactMerge_CTRL.getDuplicateRecordSets instead of hardcoding another duplicate rule check and manipulate the existing CSS?

andrewyu-salesforce
andrewyu-salesforce reviewed Mar 3, 2025
View reviewed changes
force-app/main/default/pages/CON_ContactMerge.page
<apex:outputField value="{!drs.DuplicateRuleId}"/>
</span>
<div>
<apex:outputPanel rendered="{!NOT(duplicateRuleStatusMap[drs.DuplicateRuleId])}"
Copy link
Contributor

@andrewyu-salesforce andrewyu-salesforce Mar 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salesforce-suyash-more Everything looks good besides the a11y focusing issue. It seems like the tooltip is not focusable, which is an a11y violation.

Copy link
Contributor Author

@salesforce-suyash-more salesforce-suyash-more Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewyu-salesforce I have made some changes to address the focusable issue, please take a look.

Base automatically changed from feature/256 to main March 28, 2025 13:41
@daniel-fuller
Copy link
Contributor

daniel-fuller commented Apr 1, 2025

This should not be merged for the 256 release. This will carry over to 258 and should be rebased against feature/258 once that feature branch is created.

andrewyu-salesforce
andrewyu-salesforce approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@andrewyu-salesforce andrewyu-salesforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the focus looks good.

@salesforce-suyash-more salesforce-suyash-more changed the base branch from main to feature/258 May 20, 2025 06:41
Base automatically changed from feature/258 to main August 1, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewyu-salesforce andrewyu-salesforce andrewyu-salesforce approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@salesforce-suyash-more @andrewyu-salesforce @daniel-fuller