fix: use non-blocking dialog when settings.json is corrupted - #439
Conversation
Replace dialog.showMessageBoxSync() with the async dialog.showMessageBox() in settingsStore.load(). The synchronous modal previously blocked the entire startup sequence during app.whenReady() until the user dismissed it, which hung indefinitely on headless systems and automated environments. Defaults are now returned immediately and the warning is shown asynchronously without blocking initialization.
|
@Kirtan-pc is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🎉 Congratulations @Kirtan-pc! 🎉 Your pull request has been successfully merged into Paraline! Thank you so much for your valuable contribution and effort. Every single improvement helps make Paraline a better desktop experience for everyone! 🙌 🚀 What's Next?
💬 Stay Connected: Thank you again, and keep up the amazing work! 💻✨ |
Description
Fixes startup blocking when
settings.jsonis corrupted by removing the synchronous modal dialog from the settings load path.Changes
dialog.showMessageBoxSync()with the asyncdialog.showMessageBox()insettingsStore.load().Related Issue
Closes #405
Testing
npm testBenefits