fix: restart simulated audio fallback after visualizer reload - #440
Conversation
reloadVisualizer() stopped the simulated audio fallback timer but never restarted it when the audio helper was still disconnected, leaving the visualizer with permanent zero audio input. Restart the fallback after reloading whenever the helper is not the active bridge mode.
|
@Kirtan-pc is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🎉 Congratulations @Kirtan-pc! 🎉 Your pull request has been successfully merged into Paraline! Thank you so much for your valuable contribution and effort. Every single improvement helps make Paraline a better desktop experience for everyone! 🙌 🚀 What's Next?
💬 Stay Connected: Thank you again, and keep up the amazing work! 💻✨ |
Description
Fixes the simulated audio fallback being permanently disabled after a visualizer reload by restarting it when the audio helper is still disconnected.
Changes
reloadVisualizer()now restartsstartSimulatedAudioFallback()after cleaning up the fallback timer when the helper is not the active bridge mode.handleAudioBridgeStatusChange()(lastBridgeMode !== "helper"and!isQuitting), so the fallback stays stopped when the helper is connected or the app is shutting down.reloadVisualizer()) keep responding to simulated audio when the helper is disconnected.Related Issue
Closes #399
Testing
npm testBenefits