Skip to content

fix: restart simulated audio fallback after visualizer reload - #440

Merged
SamXop123 merged 1 commit into
SamXop123:mainfrom
Kirtan-pc:fix/restart-simulated-audio-fallback-on-reload
Aug 5, 2026
Merged

fix: restart simulated audio fallback after visualizer reload#440
SamXop123 merged 1 commit into
SamXop123:mainfrom
Kirtan-pc:fix/restart-simulated-audio-fallback-on-reload

Conversation

@Kirtan-pc

Copy link
Copy Markdown
Contributor

Description

Fixes the simulated audio fallback being permanently disabled after a visualizer reload by restarting it when the audio helper is still disconnected.

Changes

  • reloadVisualizer() now restarts startSimulatedAudioFallback() after cleaning up the fallback timer when the helper is not the active bridge mode.
  • The restart is guarded by the same conditions used in handleAudioBridgeStatusChange() (lastBridgeMode !== "helper" and !isQuitting), so the fallback stays stopped when the helper is connected or the app is shutting down.
  • Visualizers reloaded via the context menu "Reload" option (or any code path calling reloadVisualizer()) keep responding to simulated audio when the helper is disconnected.
  • Real helper audio behavior is unchanged.

Related Issue

Closes #399

Testing

  • Verified all 43 unit tests pass with:
npm test
  • Verified whitespace and formatting checks:
git diff --check

Benefits

  • Audio reactivity no longer dies permanently after reloading the visualizer while the helper is disconnected.
  • The simulated audio fallback resumes immediately after reload instead of requiring a helper reconnect or app restart.
  • No behavioral change when the audio helper is connected.

reloadVisualizer() stopped the simulated audio fallback timer but never
restarted it when the audio helper was still disconnected, leaving the
visualizer with permanent zero audio input. Restart the fallback after
reloading whenever the helper is not the active bridge mode.
@vercel

vercel Bot commented Aug 2, 2026

Copy link
Copy Markdown

@Kirtan-pc is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 745e6c75-d749-49e0-8253-f1dcf73f259a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SamXop123
SamXop123 merged commit 8283b8f into SamXop123:main Aug 5, 2026
5 of 7 checks passed
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

🎉 Congratulations @Kirtan-pc! 🎉

Your pull request has been successfully merged into Paraline! Thank you so much for your valuable contribution and effort. Every single improvement helps make Paraline a better desktop experience for everyone! 🙌

🚀 What's Next?

  • Keep the momentum going! Feel free to browse through our open Issues and grab another one that interests you!
  • Support the Project: If you enjoyed contributing to Paraline, please take a second to star our repository! It helps increase the project's visibility and supports our community. ⭐

💬 Stay Connected:
Have any questions, want feedback, or just want to discuss further contributions? Feel free to reach out directly to the maintainer on Discord: dot_notsam!

Thank you again, and keep up the amazing work! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] reloadVisualizer() kills simulated audio fallback permanently

2 participants