remove HasOffset feature, change offset parameter meaning#51
Open
markus-zolliker wants to merge 4 commits into
Open
remove HasOffset feature, change offset parameter meaning#51markus-zolliker wants to merge 4 commits into
markus-zolliker wants to merge 4 commits into
Conversation
offset is now a predefined parameter
birkenfeld
reviewed
May 13, 2026
|
|
||
| Definition: | ||
|
|
||
| | ``offset`` = ``value`` - raw value |
Member
There was a problem hiding this comment.
This is now the non-NICOS convention :)
Contributor
Author
There was a problem hiding this comment.
Sorry, I was confused in the meeting about the sign, and I did not check myself. I will change it.
|
|
||
|
|
||
| When a SEC node receives a ``change`` message for an ``offset``, | ||
| ``value`` must be updated before the ``changed`` message is replied to the client. |
Member
There was a problem hiding this comment.
I guess "value must be updated" refers to emitting an update message, but could it be worded more clear?
Contributor
Author
There was a problem hiding this comment.
If we want to be explicit: "When a SEC node receives a change message for an offset, it must sent an update message for value to all activated clients before the changed message is replied".
Contributor
Author
There was a problem hiding this comment.
I assume your comment was for the next commit 7276af8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
offset is now a predefined parameter