[NUI] Add Gesture related APIs by TCSACR-651#7657
Conversation
Public API ChangedPlease follow the ACR process for the changed API below. Internal API ChangedAdded: 0, Removed: 109, Changed: 0 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request promotes several gesture-related APIs to public status by replacing internal attributes with the <since_tizen> 10.1 </since_tizen> tag and renaming various 'TouchesRequired' methods to 'TouchCount' for better clarity. Feedback focuses on maintaining naming consistency; while several setters were renamed, their corresponding getters (e.g., GetMinimumTouchesRequired) were not, leading to an inconsistent public API. Additionally, a high-severity issue was noted in PanGestureDetector.cs where the ScreenPosition property appears to be a stub returning a default value rather than fetching data from the native layer.
Public API ChangedPlease follow the ACR process for the changed API below. Internal API ChangedAdded: 0, Removed: 109, Changed: 0 |
Public API ChangedPlease follow the ACR process for the changed API below. Internal API ChangedAdded: 0, Removed: 109, Changed: 0 |
| mPanGestureDetector.Attach(this); | ||
| mPanGestureDetector.AddDirection(PanGestureDetector.DirectionVertical); | ||
| if (mPanGestureDetector.GetMaximumTouchesRequired() < 2) mPanGestureDetector.SetMaximumTouchesRequired(2); | ||
| if (mPanGestureDetector.GetMaximumTouchesRequired() < 2) mPanGestureDetector.SetMaximumTouchCount(2); |
There was a problem hiding this comment.
🤖 [AI Review]
🔴 Critical: Public-API setter/getter pair naming is asymmetric after this rename — setters became *TouchCount/*TapCount but the matching getters were kept as *TouchesRequired/*TapsRequired. The inconsistency is visible in-line here (GetMaximumTouchesRequired() next to SetMaximumTouchCount(2)). Since these APIs are being newly exposed in this PR (previously [EditorBrowsable(Never)]), renaming the getters in lock-step (GetMinimumTouchCount/GetMaximumTouchCount in PanGestureDetector/LongPressGestureDetector; GetMinimumTapCount/GetMaximumTapCount in TapGestureDetector) avoids a follow-up breaking rename after release.
3 participants
Description of Change
[NUI] Add Gesture related APIs by TCSACR-651
API Changes
https://jira.sec.samsung.net/browse/TCSACR-651