Harden active notification button indexing#7665
Open
AI-DEV-BOT wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request improves the button index assignment and validation logic in NotificationActiveStyle.cs by searching for the first available index within the valid range (First to Third) when no index is specified, and throwing appropriate exceptions for invalid or overflowing indices. There are no review comments, and I have no additional feedback to provide.
Member
|
🤖 [AI Review] Reviewed — no findings. Scope checked:
No 🔴 critical issues, no 🟡 suggestions to flag. Automated review — final merge decision rests with human reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix active notification button index assignment in
NotificationActiveStyle.AddButtonAction().When a
ButtonActionis added withButtonIndex.None, the method now assigns the first unused supported button slot fromButtonIndex.FirstthroughButtonIndex.Thirdinstead of deriving the index frombuttonDictionary.Count. This avoids invalid indexes after three buttons and prevents duplicate-key failures when buttons have been removed.Explicit button indexes are also validated so values outside the supported active notification button range fail with
NotificationError.InvalidParameter.Validation:
git diff --checkAPI Changes
None.