[Tizen.Security.PrivacyPrivilegeManager][Non-ACR] Fix multiple priv. callback#7718
Open
TomaszSwierczek wants to merge 1 commit into
Open
[Tizen.Security.PrivacyPrivilegeManager][Non-ACR] Fix multiple priv. callback#7718TomaszSwierczek wants to merge 1 commit into
TomaszSwierczek wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the MultipleRequestHandler method in PrivacyPrivilegeManager.cs to conditionally populate the Result field of PermissionRequestResponse only when the cause is CallCause.Answer. The review feedback suggests refactoring this implementation to eliminate duplicated array allocation and loop structures by using a ternary operator within a single loop.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…ege callback management In case the callback is called for reason different than actual answer, underlying native implementation is not populating the results array and code cannot iterate over it. Similar check was already present in single-privilege callback C# code where result wasn't reached for in case of non-answer call. This commit fixes this behaviour for multiple-privileges callback. Co-Authored-By: Cline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case the callback is called for reason different than actual answer, underlying native implementation is not populating the results array and code cannot iterate over it.
Similar check was already present in single-privilege callback C# code where result wasn't reached for in case of non-answer call.
This commit fixes this behaviour for multiple-privileges callback.