Skip to content

Refresh component when attributes change #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
armiiller wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refresh component when attributes change #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e40126
Refresh the timer when attributes change
armiiller Sep 12, 2017
dda17d4
Merge pull request #1 from armiiller/armiiller-patch-didupdateattrs
armiiller Sep 12, 2017
f220f41
Don't hardcode the element type
armiiller Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions addon/components/x-timer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,19 @@ export default Ember.Component.extend({
//TODO: check the usage of this variable
isRunning: false,

didInsertElement: function(){
if(this.get("autoStart")){
_init: function _init() {
if (this.get("autoStart")) {
this.send("start");
}
},

didInsertElement: function(){
this._init();
},

didUpdateAttrs: function didUpdateAttrs() {
this._init();
},

showStartBtn: function(){
return this.get("isStopWatch") || !this.get("autoStart");
Expand Down
2 changes: 1 addition & 1 deletion app/templates/components/x-timer.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<h4>{{duration}}</h4>
{{duration}}
{{#if showStartBtn}}
<button type="submit" class="btn btn-sm btn-default" {{action "start"}}>Start</button>
{{/if}}
Expand Down