Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 196869980b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const incremental = await this.ariaSnapshot({ | ||
| timeout: options.timeout, | ||
| depth: options.depth, | ||
| mode: 'ai', | ||
| _track: options.track, |
There was a problem hiding this comment.
Avoid split snapshotForAI into two independent snapshots
snapshotForAI() now issues one ariaSnapshot() for full and a second ariaSnapshot() with track for incremental, so the two payloads can come from different DOM states when the page is changing (timers, network updates, animations). That breaks the previous single-call behavior where full/incremental were consistent with each other, and it can also exceed the caller’s expected timeout budget because each RPC gets the full timeout independently.
Useful? React with 👍 / 👎.
1968699 to
c41752e
Compare
Summary
playwrightandplaywright-coreversions to1.59.1across the repo and embedded runtime package manifestsv1.59.1and reapply the sandbox-specific patches and stubssnapshotForAI()on top of Playwright's newariaSnapshot({ mode: "ai" })flowValidation
cd daemon && pnpm run bundle && pnpm run bundle:sandbox-clientcd daemon && npx tsc --noEmitcd daemon && pnpm vitest runcd cli && cargo build && cargo fmt -- --check