Skip to content

feat: upgrade Playwright to 1.59.1#96

Open
SawyerHood wants to merge 1 commit intomainfrom
dev-browser-pw-upgrade
Open

feat: upgrade Playwright to 1.59.1#96
SawyerHood wants to merge 1 commit intomainfrom
dev-browser-pw-upgrade

Conversation

@SawyerHood
Copy link
Copy Markdown
Owner

Summary

  • upgrade pinned playwright and playwright-core versions to 1.59.1 across the repo and embedded runtime package manifests
  • refresh the forked QuickJS client from upstream v1.59.1 and reapply the sandbox-specific patches and stubs
  • preserve dev-browser convenience APIs like snapshotForAI() on top of Playwright's new ariaSnapshot({ mode: "ai" }) flow

Validation

  • cd daemon && pnpm run bundle && pnpm run bundle:sandbox-client
  • cd daemon && npx tsc --noEmit
  • cd daemon && pnpm vitest run
  • cd cli && cargo build && cargo fmt -- --check

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 196869980b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +871 to +875
const incremental = await this.ariaSnapshot({
timeout: options.timeout,
depth: options.depth,
mode: 'ai',
_track: options.track,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid split snapshotForAI into two independent snapshots

snapshotForAI() now issues one ariaSnapshot() for full and a second ariaSnapshot() with track for incremental, so the two payloads can come from different DOM states when the page is changing (timers, network updates, animations). That breaks the previous single-call behavior where full/incremental were consistent with each other, and it can also exceed the caller’s expected timeout budget because each RPC gets the full timeout independently.

Useful? React with 👍 / 👎.

@SawyerHood SawyerHood force-pushed the dev-browser-pw-upgrade branch from 1968699 to c41752e Compare April 2, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant