Skip to content

fix(pdfx): guard rawDocumentProgress against NaN/Infinity in PdfViewPinch #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarkianUchiha wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pdfx): guard rawDocumentProgress against NaN/Infinity in PdfViewPinch #621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/pdfx/lib/src/viewer/pinch/pdf_view_pinch.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,18 @@ class _PdfViewPinchState extends State<PdfViewPinch>
-m.row0[3], -m.row1[3], _lastViewSize!.width, _lastViewSize!.height);

if (_lastViewSize?.height != null) {
final rawDocumentProgress =
// Cuando el documento cabe exactamente en el viewport (o cuando ambos
// aún miden 0 en el primer frame en Android edge-to-edge), el divisor
// (_docSize.height - _lastViewSize.height) es 0 y produce NaN/Infinity.
// Sin este guard, .round() crashea con "Infinity or NaN toInt" y el
// PDF se queda en blanco. Al normalizar a 0.0 el progreso es
// consistente: no hay recorrido pendiente cuando todo cabe en pantalla.
var rawDocumentProgress =
((exposed.bottom / r - _lastViewSize!.height) /
(_docSize!.height - _lastViewSize!.height));
if (rawDocumentProgress.isNaN || rawDocumentProgress.isInfinite) {
rawDocumentProgress = 0.0;
}
const precisionFactor = 10000;
_controller._documentProgress =
((rawDocumentProgress * precisionFactor).round() / precisionFactor)
Expand Down