Skip to content

add schemas for PDM#3466

Merged
hyperupcall merged 15 commits into
SchemaStore:masterfrom
jvllmr:master
Dec 21, 2023
Merged

add schemas for PDM#3466
hyperupcall merged 15 commits into
SchemaStore:masterfrom
jvllmr:master

Conversation

@jvllmr

@jvllmr jvllmr commented Dec 20, 2023

Copy link
Copy Markdown
Contributor
  • added pdm.json
  • added partial-pdm.json

closes #3465

@jvllmr jvllmr changed the title add jsonschema for pdm.toml add jsonschema for PDM Dec 20, 2023
@henryiii

Copy link
Copy Markdown
Contributor

I think the plan is to name partial schemas (for tool tables) as partial-<tool>, see #3422.

@hyperupcall

Copy link
Copy Markdown
Member

Thanks for your contribution! Yeah this isn't quite documented yet - that issue has more information - the gist of it is:

  • If a schema represents an existing project, that could be its own file (even if INI), then keep the name the same (what is already done)
  • If the schema cannot be its own file, prefixpartial- (partial-mypy.json). If later the project supports a stanadlone config file, we can always $ref the partial.

Since it looks like the current "PDM Pyproject" project doesn't have it's own configuration file (pdm.toml looks to be an entirely different schema), then best would be to name it as partial-pdm.json

@jvllmr

jvllmr commented Dec 21, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the hint. Will change it asap.

mutually exclusive keys are ignored for now
@jvllmr

jvllmr commented Dec 21, 2023

Copy link
Copy Markdown
Contributor Author

I guess the PR is ready for review now. Let me know if you find issues.

@jvllmr jvllmr marked this pull request as ready for review December 21, 2023 19:46
@jvllmr jvllmr changed the title add jsonschema for PDM add schemas for PDM Dec 21, 2023
@hyperupcall

Copy link
Copy Markdown
Member

awesome, thank you

@hyperupcall hyperupcall merged commit 4a2a85f into SchemaStore:master Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PDM Schema

3 participants