fix(Jobs): fix jobs fullfacet access with text#2736
Open
abdimo101 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new logic assumes
pipeline[0]always exists and is a$matchstage whenfields['text']is set; consider adding a guard or explicit validation so you don't accessfirstStage.$matchwhen the pipeline is empty or starts with a different stage. - Instead of checking
if (fields['text']), it may be safer to check explicitly for the presence of a text search stage (or a specific field structure) in the pipeline, so that access control merging is only applied when the first stage is actually the$text$matchyou expect.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new logic assumes `pipeline[0]` always exists and is a `$match` stage when `fields['text']` is set; consider adding a guard or explicit validation so you don't access `firstStage.$match` when the pipeline is empty or starts with a different stage.
- Instead of checking `if (fields['text'])`, it may be safer to check explicitly for the presence of a text search stage (or a specific field structure) in the pipeline, so that access control merging is only applied when the first stage is actually the `$text` `$match` you expect.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR places a check if the pipeline contains a text and merges access to the text match so MongoDB accepts the pipeline and access is still enforced.
Motivation
When searching in Jobs table, the fullfacet endpoint throws an error:
"{status: 400, message: "$match with $text is only allowed as the first pipeline stage"}
message
:
"$match with $text is only allowed as the first pipeline stage"
status
:
400"
Fixes
Changes:
Tests included
Documentation
official documentation info
Summary by Sourcery
Bug Fixes: