feat(jwt-auth): throw 401 session expired error for expired token#2737
Open
abdellah257 wants to merge 1 commit into
Open
feat(jwt-auth): throw 401 session expired error for expired token#2737abdellah257 wants to merge 1 commit into
abdellah257 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Instead of typing
infoasany, consider using a more specific type (e.g. the Passport/JWT error type or a narrow union) so thatinfo?.name === "TokenExpiredError"is type-safe and self-documenting. - If
"SESSION_EXPIRED"is reused or needs localization, consider extracting it into a shared constant or an error code enum to avoid hardcoding the string in the guard.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of typing `info` as `any`, consider using a more specific type (e.g. the Passport/JWT error type or a narrow union) so that `info?.name === "TokenExpiredError"` is type-safe and self-documenting.
- If `"SESSION_EXPIRED"` is reused or needs localization, consider extracting it into a shared constant or an error code enum to avoid hardcoding the string in the guard.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Throw a
401status HTTP error withSESSION_EXPIREDmessage, for jwt authentication with an expired token.Motivation
Separate the session expired errors, from the
403unauthorized errors, to inform the user of session expiration instead of silently failing.Changes:
jwt-auth.guard.tsmaking use of theinfofield in case of Token Expired.Tests included
Documentation
official documentation info
Summary by Sourcery
Bug Fixes: