Skip to content

feat: add mark for deletion buttons#2334

Closed
minottic wants to merge 4 commits into
masterfrom
mark_button
Closed

feat: add mark for deletion buttons#2334
minottic wants to merge 4 commits into
masterfrom
mark_button

Conversation

@minottic
Copy link
Copy Markdown
Member

@minottic minottic commented Apr 15, 2026

Description

Add mark for deletion workflow taking options from config

Motivation

Background on use case, changes needed

Fixes:

Please provide a list of the fixes implemented in this PR

  • Items added

Changes:

Please provide a list of the changes implemented by this PR

  • changes made

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Introduce configurable mark-for-deletion workflow for datasets, including UI actions, dialog support, and job submission handling alongside existing archive/retrieve flows.

New Features:

  • Add mark-for-deletion actions to dataset table and batch views, controlled by configuration codes.
  • Add dynamic dialog support for selecting deletion reason and explanation when marking datasets for deletion.
  • Extend archiving service with a mark-for-deletion job type and dialog configuration derived from app config.

Enhancements:

  • Refactor archiving job creation and archive/retrieve handling to use explicit job types and generic additional job parameters.
  • Generalize dialog component to support dynamic fields and reusable choice-based forms.
  • Extend app configuration to carry dialog option data for retrieve destinations and mark-for-deletion codes.

Tests:

  • Add unit tests for mark-for-deletion flows in dataset table actions and batch view components, including success and error handling.
  • Add unit tests for new archiving service mark-for-deletion methods and dialog options.
  • Expand dialog component tests for dynamic fields and cancel behavior.

@minottic
Copy link
Copy Markdown
Member Author

superseeded by #2351

@minottic minottic closed this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant