fix(UI): hide disabled dataset filters#2363
Open
abdimo101 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new Cypress test relies on
cy.contains('Keyword')andcy.contains('Type')without scoping to the filters section, which can lead to brittle tests if the same text appears elsewhere; consider scoping these assertions to the filters container or using a dedicated data attribute for the filter labels.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new Cypress test relies on `cy.contains('Keyword')` and `cy.contains('Type')` without scoping to the filters section, which can lead to brittle tests if the same text appears elsewhere; consider scoping these assertions to the filters container or using a dedicated data attribute for the filter labels.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR hides disabled filters in Datasets Filters section
Motivation
Background on use case, changes needed
Fixes:
Please provide a list of the fixes implemented in this PR
Changes:
Please provide a list of the changes implemented by this PR
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version
Summary by Sourcery
Tests: