Skip to content

fix(UI): hide disabled dataset filters#2363

Open
abdimo101 wants to merge 1 commit into
masterfrom
fix-disabled-filters
Open

fix(UI): hide disabled dataset filters#2363
abdimo101 wants to merge 1 commit into
masterfrom
fix-disabled-filters

Conversation

@abdimo101
Copy link
Copy Markdown
Member

@abdimo101 abdimo101 commented May 6, 2026

Description

This PR hides disabled filters in Datasets Filters section

Motivation

Background on use case, changes needed

Fixes:

Please provide a list of the fixes implemented in this PR

  • Items added

Changes:

Please provide a list of the changes implemented by this PR

  • changes made

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Tests:

  • Add Cypress test to verify that disabled dataset filters are not rendered while enabled ones remain visible.

@abdimo101 abdimo101 requested a review from a team as a code owner May 6, 2026 12:16
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new Cypress test relies on cy.contains('Keyword') and cy.contains('Type') without scoping to the filters section, which can lead to brittle tests if the same text appears elsewhere; consider scoping these assertions to the filters container or using a dedicated data attribute for the filter labels.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new Cypress test relies on `cy.contains('Keyword')` and `cy.contains('Type')` without scoping to the filters section, which can lead to brittle tests if the same text appears elsewhere; consider scoping these assertions to the filters container or using a dedicated data attribute for the filter labels.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@abdimo101 abdimo101 requested review from Junjiequan and nitrosx May 6, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant