fix: dataset breadcrumb navigation to avoid history back on repeated clicks#2388
Draft
Copilot wants to merge 2 commits into
Draft
fix: dataset breadcrumb navigation to avoid history back on repeated clicks#2388Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/SciCatProject/frontend/sessions/23a2179b-876f-48c3-9844-6aa7f3b51d27 Co-authored-by: Junjiequan <78078898+Junjiequan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix redirect on double click of Datasets header path
Fix dataset breadcrumb navigation to avoid history back on repeated clicks
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dataset detail pages, clicking the first breadcrumb (
Datasets) could invoke browser history (back) and send users to the previous URL, including external pages. This PR makes breadcrumb navigation deterministic by always routing to the datasets list path.Navigation behavior update
Datasetsbreadcrumb now consistently resolves to/datasetsregardless of prior browser history state.Breadcrumb click path consistency
url + crumb.url) and applied it to the datasets branch, aligning behavior with the non-datasets branch.Focused unit coverage
/datasets(instead of history back behavior).Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
accounts.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4966 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-4084052 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2565522027097625640,400050732347450987,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,18375531892440345325,15497792245122346784,4 --trace-process-track-uuid=3190708989122997041 /frontend end(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-4084052 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost:9876/?id=4084052(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5235 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-81925954 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4231587736625820888,9689134619177768915,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12458521445050126938,10480404251393704005,4 --trace-process-track-uuid=3190708989122997041(dns block)android.clients.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4966 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-4084052 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2565522027097625640,400050732347450987,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,18375531892440345325,15497792245122346784,4 --trace-process-track-uuid=3190708989122997041 /frontend end(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-4084052 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost:9876/?id=4084052(dns block)clients2.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4966 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-4084052 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2565522027097625640,400050732347450987,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,18375531892440345325,15497792245122346784,4 --trace-process-track-uuid=3190708989122997041 /frontend end(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-4084052 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost:9876/?id=4084052(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5235 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-81925954 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4231587736625820888,9689134619177768915,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12458521445050126938,10480404251393704005,4 --trace-process-track-uuid=3190708989122997041(dns block)clientservices.googleapis.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4966 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-4084052 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2565522027097625640,400050732347450987,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,18375531892440345325,15497792245122346784,4 --trace-process-track-uuid=3190708989122997041 /frontend end(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-4084052 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost:9876/?id=4084052(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5235 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-81925954 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4231587736625820888,9689134619177768915,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12458521445050126938,10480404251393704005,4 --trace-process-track-uuid=3190708989122997041(dns block)download.cypress.io/usr/local/bin/node node dist/index.js --exec install(dns block)google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4966 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-4084052 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2565522027097625640,400050732347450987,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,18375531892440345325,15497792245122346784,4 --trace-process-track-uuid=3190708989122997041 /frontend end(dns block)optimizationguide-pa.googleapis.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4966 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-4084052 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2565522027097625640,400050732347450987,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,18375531892440345325,15497792245122346784,4 --trace-process-track-uuid=3190708989122997041 /frontend end(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-4084052 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost:9876/?id=4084052(dns block)redirector.gvt1.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4966 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-4084052 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2565522027097625640,400050732347450987,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,18375531892440345325,15497792245122346784,4 --trace-process-track-uuid=3190708989122997041 /frontend end(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-4084052 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost:9876/?id=4084052(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5235 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-81925954 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4231587736625820888,9689134619177768915,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12458521445050126938,10480404251393704005,4 --trace-process-track-uuid=3190708989122997041(dns block)safebrowsingohttpgateway.googleapis.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4966 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-4084052 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2565522027097625640,400050732347450987,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,18375531892440345325,15497792245122346784,4 --trace-process-track-uuid=3190708989122997041 /frontend end(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-4084052 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost:9876/?id=4084052(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5235 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-81925954 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4231587736625820888,9689134619177768915,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12458521445050126938,10480404251393704005,4 --trace-process-track-uuid=3190708989122997041(dns block)sb-ssl.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4966 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-4084052 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2565522027097625640,400050732347450987,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,18375531892440345325,15497792245122346784,4 --trace-process-track-uuid=3190708989122997041 /frontend end(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-4084052 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost:9876/?id=4084052(dns block)www.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4966 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-4084052 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2565522027097625640,400050732347450987,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,18375531892440345325,15497792245122346784,4 --trace-process-track-uuid=3190708989122997041 /frontend end(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-4084052 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost:9876/?id=4084052(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5235 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-81925954 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4231587736625820888,9689134619177768915,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12458521445050126938,10480404251393704005,4 --trace-process-track-uuid=3190708989122997041(dns block)www.scicat.info/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4966 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-4084052 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2565522027097625640,400050732347450987,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,18375531892440345325,15497792245122346784,4 --trace-process-track-uuid=3190708989122997041 /frontend end(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-4084052 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost:9876/?id=4084052(dns block)zip.scicatproject.org/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=4966 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-4084052 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,2565522027097625640,400050732347450987,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,18375531892440345325,15497792245122346784,4 --trace-process-track-uuid=3190708989122997041 /frontend end(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-4084052 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost:9876/?id=4084052(dns block)If you need me to access, download, or install something from one of these locations, you can either: