docs: add cauer low pass analog filter example#240
docs: add cauer low pass analog filter example#240jvaverka wants to merge 5 commits intoSciML:mainfrom jvaverka:add-example-doc-tests
Conversation
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 16.02% 15.99% -0.03%
==========================================
Files 48 48
Lines 1629 1638 +9
==========================================
+ Hits 261 262 +1
- Misses 1368 1376 +8 see 3 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
|
||
| ```plaintext | ||
| ERROR: Default algorithm choices require DifferentialEquations.jl. | ||
| Please specify an algorithm (e.g., `solve(prob, Tsit5())` or |
There was a problem hiding this comment.
Perhaps we can suggest using DifferentialEquations and solve(prob) instead of OrdinaryDiffEq?
(While keeping the note+url on where they can find all the solvers they can specify if they want to.)
There was a problem hiding this comment.
You mean for all the tutorials? Seems like a good idea to me. My understanding of the trade-off being OrdinaryDiffEq.jl is more lightweight and therefore faster to load, but DifferentialEquations.jl is more robust and offers conveniences to new users - which is useful for readers going through the tutorials.
Should I leave the note, and open an issue to switch over all tutorials and update docs/Project.toml?
|
I'm keeping the Units PR open till upcoming breaking release; it would invalidate any model that use these along with unitless parameters. I can add units to this tutorial in that PR. |
Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com>
Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com>
I would be happy to add units after #214 is merged. Originally, I wrote the example to include units but then hit errors and had to remove them. |
No description provided.