Merged
Conversation
- Remove duplicate initial condition for PT2 test (pt2.xd already in unknowns) - Remove bound parameter IC setting for PI/LimPI tests (gainPI.k is bound) - Replace deprecated @mtkbuild with @mtkcompile in analog electrical tests - Fix deprecated integer indexing on DiffEqArray in hydraulic actuator test - Remove unused deprecated imports (get_eqs, vars, @set!) in analysis points test - Fix linearize call to not wrap scalars in vectors Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pt2.xdalready included inunknowns(sys) .=> 0.0)gainPI.kis a bound parameter, can't set initial conditions on it)@mtkbuildwith@mtkcompilein analog electrical tests (4 occurrences)DiffEqArrayin hydraulic actuator test (initsol[1]→initsol.u[end]), and provide all unknowns instead of just firstget_eqs,vars,@set!) in analysis points testlinearizecall to not wrap scalar analysis point inputs/outputs in vectorsTest Results
With
JULIA_DEPWARN=error:port.ρkeys ininitial_conditionsdict) — these fail with or withoutJULIA_DEPWARN=errorUpstream Dependencies Needing Fixes
The following pre-existing issues are not caused by deprecation warnings but are blocking a fully clean test run:
initial_conditionsdict): Bound port parameters likesrc.port.ρ,valve.port_s.ρ, etc. are no longer accessible viainitial_conditions(sys)dict indexing — causes 6 KeyErrors in the Actuator System testsymbolic_container(::ModelingToolkitBase.IndexCache)method is missing — causes analysis points test failure (currently passing due to@test_brokenor error being caught)Base.getindex(VA::AbstractDiffEqArray, i::Int)is deprecated in favor ofVA.u[i]— fixed in this PR for the one occurrence in test codeTest plan
JULIA_DEPWARN=error julia --project -e 'using Pkg; Pkg.test()'@mtkcompile🤖 Generated with Claude Code