Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
74 tasks
z-Fng
force-pushed
the
fix-checkver
branch
2 times, most recently
from
d5eb263 to
e583bc1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. abc
ammonite
arc
aria2
atomicparsley
autocorrect
avro-tools
binaryen
camunda-operate
capnp
capstone
coq
cormanlisp
crystal
ddosify
detekt
dirhash
dxc
gauche
gitoxide
go-feature-flag
gobang
gource
grails
grpcurl
hashlink
hatch
jq
kim
knative
kotlin-native
less
lf
lua-for-windows
marksman
metastore
minio-client
naiveproxy
neko
ninja-kitware
nyagos
openssh
pdf2djvu
perl
pt
sleuthkit
suanpan
swc
tea
terraformer
v
xidel
yara
z.lua
z3
|
chawyehsu
reviewed
May 9, 2026
| "github": "https://api.github.com/repos/GoogleCloudPlatform/terraformer/releases", | ||
| "jsonpath": "$..browser_download_url", | ||
| "regex": "download/([\\d.]+)/terraformer-all-windows-amd64" | ||
| }, |
Member
There was a problem hiding this comment.
I'm confused, the original checkver of terraformer still works after Scoop core changes. May I ask why do we need to update it to this?
Member
There was a problem hiding this comment.
I haven't reviewed other changes, but they look suspicious to me.
Member
Author
There was a problem hiding this comment.
May I ask why do we need to update it to this?
This change was made to pin Terraformer to version 0.8.24 and suppress error logs.
Terraform is currently at version 0.8.30. It does not include a Windows binary (-all) compatible with all cloud platforms. Instead, it has been split according to cloud platforms. If we were to update the manifest to version 0.8.30, I wouldn't know which cloud platform's binary to use. We can't very well ask users to download a dozen or so different binaries, can we? So I think it’s fine to keep it at version 0.8.24.
Error logs:
https://github.com/ScoopInstaller/Main/actions/runs/25592883440/job/75133596306
terraformer: 0.8.30 (scoop version is 0.8.24) autoupdate available
Autoupdating terraformer
Could not find hash in https://api.github.com/repos/GoogleCloudPlatform/terraformer/releases
Downloading terraformer.exe to compute hashes!
The remote server returned an error: (404) Not Found.
URL https://github.com/GoogleCloudPlatform/terraformer/releases/download/0.8.30/terraformer-all-windows-amd64#/terraformer.exe is not valid
ERROR Could not update terraformer, hash for terraformer.exe failed!
I haven't reviewed other changes, but they look suspicious to me.
Other similar changes (https://github.com/ScoopInstaller/Main/compare/d5eb263df6b6d1f3a433900696fe53cd9926749c..e583bc15940c614a3e999a5a3df277767fc61e6b), which may be slightly outside the scope of the PR title, were made for similar reasons to suppress error logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<manifest-name[@version]|chore>: <general summary of the pull request>