[BOUNTY] Add Signature Verification to /relay/ping — 10 RTC#331
Closed
dannamax wants to merge 1 commit intoScottcjn:mainfrom
Closed
[BOUNTY] Add Signature Verification to /relay/ping — 10 RTC#331dannamax wants to merge 1 commit intoScottcjn:mainfrom
dannamax wants to merge 1 commit intoScottcjn:mainfrom
Conversation
Owner
|
Closing — this duplicates functionality already merged in beacon-skill PRs #34 and #38 which implement relay/ping signature verification inline. Also the DB path is wrong ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Bounty: Add Signature Verification to /relay/ping — 10 RTC
This PR implements Ed25519 signature verification for the
/relay/pingendpoint in Beacon Atlas, addressing the security vulnerability where attackers could impersonate relay agents by sending fake pings with anyagent_id.Implementation Details
Since the
/relay/pingendpoint is part of the separate Beacon Atlas application (not included in this RustChain repository), I've implemented a modular signature verification solution that can be easily integrated:✅ Core Module:
beacon_signature_verification.pyverify_relay_ping_signature()function for signature verification/relay/registerbeacon-skillcrypto and fallbackpynaclimplementation✅ Integration Guide
The module includes clear integration instructions with a complete code example showing exactly how to integrate signature verification into the Beacon Atlas
/relay/pingendpoint.✅ Test Suite
Key Features
/relay/registerIntegration Instructions
To integrate this solution into the Beacon Atlas application:
node/beacon_signature_verification.pyto your Beacon Atlas application directory/relay/pingendpoint handler as shown in the integration examplebeacon_atlas.dbdatabase containing therelay_agentstableThe integration example in the module shows exactly how to modify your endpoint handler to add signature verification while maintaining backward compatibility.
Testing
The included test suite can be run independently and covers:
Dependencies
pynacl(already used in RustChain for TOFU implementation)beacon-skill(optional, provides additional crypto utilities)This implementation follows the same patterns and security practices established in the recently merged TOFU key management system (PR #329), ensuring consistency across the codebase.
Fixes #307
Reward: 10 RTC