[BOUNTY] GitHub Action: RustChain Mining Status Badge — 40 RTC#337
Closed
dannamax wants to merge 2 commits intoScottcjn:mainfrom
Closed
[BOUNTY] GitHub Action: RustChain Mining Status Badge — 40 RTC#337dannamax wants to merge 2 commits intoScottcjn:mainfrom
dannamax wants to merge 2 commits intoScottcjn:mainfrom
Conversation
Contributor
liu971227-sys
left a comment
There was a problem hiding this comment.
Blocking findings:
- Docs/runtime mismatch remains for Beacon Atlas endpoints.
docs/API.mdandREADME.mdpresent/relay/registerand/relay/pingas RustChain API endpoints.- In this repository, those routes are not implemented in the RustChain node file (they belong to beacon-skill Atlas service).
- This causes immediate integration failures for users following the RustChain API docs.
/api/badge/<wallet>rejects valid short wallet IDs by policy.
- New guard:
if not wallet or len(wallet) < 10. - RustChain wallets are string IDs and existing usage/examples include short IDs; this hard minimum introduces false-invalid responses.
- Badge query is schema-fragile and can 500 on mixed deployments.
- Query uses
SELECT amount_i64 FROM balances WHERE miner_id = ? OR miner_pk = ?. - Production/history schemas are not guaranteed to include both
miner_idandminer_pksimultaneously; referencing a missing column raises SQL error and returns 500. - Please avoid querying optional/non-guaranteed columns in a single static SQL statement unless schema migration guarantees both.
Please address these before merge.
Owner
|
Closing — three issues: (1) Same destructive SECURITY.md rewrite as #335, (2) identical README/API.md changes bundled across both #335 and #337 (double-dipping), (3) bounty #256 requires a GitHub Action published to the Marketplace — this PR only adds a server endpoint (30% of requirements). The /api/badge endpoint code itself is decent, but please submit it as a focused PR without the SECURITY.md destruction and docs duplication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Issue #256: GitHub Action for RustChain mining status badges. Includes API endpoint and complete GitHub Action.