Skip to content

test(windows): restore consolidation coverage #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 2 commits into from
Jul 11, 2026
+2 −2
Merged

test(windows): restore consolidation coverage #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4823a0c
test(windows): exercise consolidation suite
ScriptedAlchemy Jul 11, 2026
757fdb7
docs(release): describe Windows recovery fixes
ScriptedAlchemy Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/windows-lifecycle-handoff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
"tracedecay": patch
---

Secure Windows update lifecycle handoff without trusting stale owner sidecars, and restore platform-neutral migration and post-update test coverage on Windows.
Secure Windows update lifecycle handoff without trusting stale owner sidecars, make migration copies durable across Windows file-lock semantics, skip unavailable daemon-service operations, and restore platform-neutral migration and post-update coverage.
2 changes: 1 addition & 1 deletion src/migrate/consolidate/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1686,5 +1686,5 @@ fn io_error(error: io::Error) -> TraceDecayError {
config_error(error.to_string())
}

#[cfg(all(test, not(windows)))]
#[cfg(test)]

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Gate the Windows-incompatible test assertion

With this cfg widened, the full consolidation suite now runs on Windows, but untracked_branch_databases_are_recovered_into_the_destination still compares a recovered db_file string to the Unix-only literal "branches/orphan-target.db". On Windows that recovered value is built from a filesystem relative path via relative.to_str(), so it uses backslashes (branches\\orphan-target.db), making the assertion false and keeping Windows CI red whenever this suite runs; normalize the assertion or keep that specific test gated.

Useful? React with 👍 / 👎.

mod tests;
Loading