Skip to content

test(lsp): stabilize fake server startup #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ScriptedAlchemy wants to merge 1 commit into from
Closed

test(lsp): stabilize fake server startup #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 29 additions & 8 deletions tests/hooks_lsp_suite/lsp_code_diagnostics_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ const FAKE_LSP_TIMEOUT: std::time::Duration = std::time::Duration::from_millis(1
// recovery helper keeps the diagnostics quiet window small so success stays
// cheap.
const FAKE_LSP_RECOVERY_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(3);
// macOS full-suite runs can briefly starve a newly spawned /usr/bin/python3
// while other test binaries are starting. Keep that harness-only startup
// allowance independent from the deliberately short diagnostics quiet window.
const FAKE_LSP_START_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(10);
const OUTER_ASYNC_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(6);
const HANGING_WRITE_LINE_COUNT: usize = 64_000;

Expand All @@ -37,6 +41,15 @@ fn recovery_fake_lsp_timeouts() -> lsp::client::LspRefreshTimeouts {
)
}

fn loaded_runner_fake_lsp_timeouts() -> lsp::client::LspRefreshTimeouts {
lsp::client::LspRefreshTimeouts::new(
FAKE_LSP_TIMEOUT,
FAKE_LSP_START_TIMEOUT,
FAKE_LSP_START_TIMEOUT,
FAKE_LSP_TIMEOUT,
)
}

#[test]
fn builtin_registry_advertises_phase_one_setup_contract() {
let adapters = lsp::adapters::builtin_adapters();
Expand Down Expand Up @@ -238,18 +251,18 @@ async fn broker_keeps_diagnostics_for_multiple_languages_in_one_snapshot() {
);

broker
.refresh_documents(
.refresh_documents_with_timeouts(
"alpha",
vec![fake_document("alpha", "src/lib.alpha", "alpha nope")],
FAKE_LSP_TIMEOUT,
loaded_runner_fake_lsp_timeouts(),
)
.await
.unwrap();
broker
.refresh_documents(
.refresh_documents_with_timeouts(
"beta",
vec![fake_document("beta", "src/lib.beta", "beta nope")],
FAKE_LSP_TIMEOUT,
loaded_runner_fake_lsp_timeouts(),
)
.await
.unwrap();
Expand Down Expand Up @@ -743,11 +756,15 @@ async fn broker_ignores_stale_refresh_completion() {
.unwrap()
.expect("latest refresh should prepare");

let latest_completed = latest.collect_diagnostics(FAKE_LSP_TIMEOUT).await;
let latest_completed = latest
.collect_diagnostics_with_timeouts(loaded_runner_fake_lsp_timeouts())
.await;
assert!(latest_completed.is_ok());
broker.finish_refresh(latest_completed).unwrap();

let stale_completed = stale.collect_diagnostics(FAKE_LSP_TIMEOUT).await;
let stale_completed = stale
.collect_diagnostics_with_timeouts(loaded_runner_fake_lsp_timeouts())
.await;
assert!(stale_completed.is_ok());
broker.finish_refresh(stale_completed).unwrap();

Expand Down Expand Up @@ -825,11 +842,15 @@ async fn broker_keys_warm_lsp_clients_by_workspace_root() {
];

broker
.refresh_documents("fake", documents.clone(), FAKE_LSP_TIMEOUT)
.refresh_documents_with_timeouts(
"fake",
documents.clone(),
loaded_runner_fake_lsp_timeouts(),
)
.await
.unwrap();
broker
.refresh_documents("fake", documents, FAKE_LSP_TIMEOUT)
.refresh_documents_with_timeouts("fake", documents, loaded_runner_fake_lsp_timeouts())
.await
.unwrap();

Expand Down
Loading