Skip to content

Comments

refactor: remove rich dependency#81

Merged
Ki-Seki merged 6 commits intomainfrom
copilot/refactor-remove-rich-usage-again
Feb 10, 2026
Merged

refactor: remove rich dependency#81
Ki-Seki merged 6 commits intomainfrom
copilot/refactor-remove-rich-usage-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 9, 2026

Plan to Remove rich Usage

  • Identify all usages of rich library in the codebase
  • Replace rich Console, Panel, Table, and Text formatting in print_beautiful_stats method with plain Python printing
  • Remove rich from dependencies in pyproject.toml
  • Run linting to ensure code quality
  • Test the changes to ensure the output still works correctly
  • Run code review and address feedback
  • Run security scan (CodeQL)
  • Remove print_beautiful_stats method entirely per reviewer feedback
  • Update uv.lock file to sync with pyproject.toml changes

Security Summary

  • ✅ CodeQL scan completed with 0 alerts
  • ✅ No security vulnerabilities introduced by the changes
  • ✅ All linting checks passed
  • ✅ Lockfile updated successfully
Original prompt

This section details on the original issue you should resolve

<issue_title>refactor: remove rich usage</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Ki-Seki <60967965+Ki-Seki@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor to remove rich usage from codebase refactor: remove rich dependency Feb 9, 2026
Copilot AI requested a review from Ki-Seki February 9, 2026 23:57
@Ki-Seki
Copy link
Member

Ki-Seki commented Feb 10, 2026

remove print_beautiful_stats(eval_results: EvalResult) -> None

@copilot

Co-authored-by: Ki-Seki <60967965+Ki-Seki@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 10, 2026

remove print_beautiful_stats(eval_results: EvalResult) -> None

@copilot

Done. Removed the print_beautiful_stats method and its call in conduct_eval. Commit: 7d71a49

@Ki-Seki Ki-Seki marked this pull request as ready for review February 10, 2026 00:30
Copilot AI review requested due to automatic review settings February 10, 2026 00:30
@Ki-Seki
Copy link
Member

Ki-Seki commented Feb 10, 2026

@copilot fix:

2026-02-10T00:31:03.2380597Z ##[group]Run uv sync --locked --dev
uv sync --locked --dev
shell: /usr/bin/bash -e {0}
env:
UV_CACHE_DIR: /home/runner/work/_temp/setup-uv-cache
Downloading cpython-3.13.7-linux-x86_64-gnu (download) (32.0MiB)
Downloading cpython-3.13.7-linux-x86_64-gnu (download)
Using CPython 3.13.7
Creating virtual environment at: .venv
Resolved 200 packages in 1.73s
The lockfile at uv.lock needs to be updated, but --locked was provided. To update the lockfile, run uv lock.
Process completed with exit code 1.

1 similar comment
@Ki-Seki
Copy link
Member

Ki-Seki commented Feb 10, 2026

@copilot fix:

2026-02-10T00:31:03.2380597Z ##[group]Run uv sync --locked --dev
uv sync --locked --dev
shell: /usr/bin/bash -e {0}
env:
UV_CACHE_DIR: /home/runner/work/_temp/setup-uv-cache
Downloading cpython-3.13.7-linux-x86_64-gnu (download) (32.0MiB)
Downloading cpython-3.13.7-linux-x86_64-gnu (download)
Using CPython 3.13.7
Creating virtual environment at: .venv
Resolved 200 packages in 1.73s
The lockfile at uv.lock needs to be updated, but --locked was provided. To update the lockfile, run uv lock.
Process completed with exit code 1.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the rich dependency by deleting the print_beautiful_stats() console-formatting helper and stopping conduct_eval() from printing formatted evaluation stats, leaving it to just run the evaluation and dump results.

Changes:

  • Removed MatchEvaluator.print_beautiful_stats() and its invocation from conduct_eval().
  • Dropped rich>=14.2.0 from pyproject.toml dependencies.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/gimbench/match/evaluators.py Removes rich-based console stats output so evaluation only produces dumped results.
pyproject.toml Removes rich from runtime dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 7 to 11
dependencies = [
"datasets>=4.4.1",
"gimkit>=0.1.1",
"rich>=14.2.0",
"vllm>=0.14.0",
]
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uv.lock still records rich as a direct dependency of gimbench (and in requires-dist), so removing it from pyproject.toml alone won’t actually drop the dependency for uv sync/locked installs. Please regenerate/update uv.lock so it no longer includes rich as a direct requirement (unless it’s still needed transitively).

Copilot uses AI. Check for mistakes.
Co-authored-by: Ki-Seki <60967965+Ki-Seki@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 10, 2026

@copilot fix:

2026-02-10T00:31:03.2380597Z ##[group]Run uv sync --locked --dev...

Fixed. Updated uv.lock to sync with the removal of rich from dependencies. Commit: 8bfc77c

@copilot fix:

2026-02-10T00:31:03.2380597Z ##[group]Run uv sync --locked --dev...

Fixed. Updated uv.lock to sync with the removal of rich from dependencies. Commit: 8bfc77c

Copilot AI requested a review from Ki-Seki February 10, 2026 00:34
@Ki-Seki Ki-Seki merged commit 73e834d into main Feb 10, 2026
3 checks passed
@Ki-Seki Ki-Seki deleted the copilot/refactor-remove-rich-usage-again branch February 10, 2026 00:37
Copilot stopped work on behalf of Ki-Seki due to an error February 10, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: remove rich usage

2 participants