Conversation
Co-authored-by: Ki-Seki <60967965+Ki-Seki@users.noreply.github.com>
rich dependency
|
remove print_beautiful_stats(eval_results: EvalResult) -> None |
Co-authored-by: Ki-Seki <60967965+Ki-Seki@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
@copilot fix: 2026-02-10T00:31:03.2380597Z ##[group]Run uv sync --locked --dev |
1 similar comment
|
@copilot fix: 2026-02-10T00:31:03.2380597Z ##[group]Run uv sync --locked --dev |
There was a problem hiding this comment.
Pull request overview
This PR removes the rich dependency by deleting the print_beautiful_stats() console-formatting helper and stopping conduct_eval() from printing formatted evaluation stats, leaving it to just run the evaluation and dump results.
Changes:
- Removed
MatchEvaluator.print_beautiful_stats()and its invocation fromconduct_eval(). - Dropped
rich>=14.2.0frompyproject.tomldependencies.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/gimbench/match/evaluators.py | Removes rich-based console stats output so evaluation only produces dumped results. |
| pyproject.toml | Removes rich from runtime dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dependencies = [ | ||
| "datasets>=4.4.1", | ||
| "gimkit>=0.1.1", | ||
| "rich>=14.2.0", | ||
| "vllm>=0.14.0", | ||
| ] |
There was a problem hiding this comment.
uv.lock still records rich as a direct dependency of gimbench (and in requires-dist), so removing it from pyproject.toml alone won’t actually drop the dependency for uv sync/locked installs. Please regenerate/update uv.lock so it no longer includes rich as a direct requirement (unless it’s still needed transitively).
Co-authored-by: Ki-Seki <60967965+Ki-Seki@users.noreply.github.com>
Fixed. Updated
Fixed. Updated |
Plan to Remove
richUsagerichlibrary in the codebaserichConsole, Panel, Table, and Text formatting inprint_beautiful_statsmethod with plain Python printingrichfrom dependencies inpyproject.tomlprint_beautiful_statsmethod entirely per reviewer feedbackSecurity Summary
Original prompt
richusage #71💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.