fix(grammar): refactor CFG generation to use llguidance suffix syntax#167
Merged
fix(grammar): refactor CFG generation to use llguidance suffix syntax#167
Conversation
Refactor the `build_cfg` function to generate a flattened grammar structure compatible with llguidance.
Key changes:
- Flatten the `start` rule to sequence tags and whitespace directly.
- Implement `[suffix="..."]` and `[capture]` attributes on lowercase rules (`m_i`) to correctly consume closing tags.
- Separate regex definitions into uppercase terminals (`M_i`), enabling safe use of greedy matching `/(?s:.*)/`.
- Add the required `%llguidance {}` header.
This resolves validation errors and prevents issues where greedy regexes swallowed closing tags or generated duplicate closures.
for more information, see https://pre-commit.ci
Member
Author
Before/After ExampleQueryquery = '<|GIM_QUERY|>The capital of <|MASKED desc="single word" regex="中国|法国"|><|/MASKED|> is Beijing<|MASKED desc="punctuation mark" regex="\\."|><|/MASKED|><|/GIM_QUERY|>'Old
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the
build_cfgfunction to generate a flattened grammar structure compatible with llguidance.Key changes:
startrule to sequence tags and whitespace directly.[suffix="..."]and[capture]attributes on lowercase rules (m_i) to correctly consume closing tags.M_i), enabling safe use of greedy matching/(?s:.*)/.%llguidance {}header.This resolves validation errors and prevents issues where greedy regexes swallowed closing tags or generated duplicate closures.