feat: no_alloc version - #14
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the ATO async runtime to eliminate heap allocation requirements, making it truly no_alloc compatible. The core change replaces boxed, heap-allocated futures with stack-pinned futures using lifetimes and introduces a task! macro for ergonomic stack pinning.
Key changes:
- Removed
allocdependency and convertedSpawnerto use stack-pinned futures with lifetime parameters - Introduced
task!macro to simplify creation of stack-pinned async blocks - Refactored
sleepandyield_nowinto separate modules for better code organization
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Removed alloc dependency, added lifetime parameter to Spawner, introduced task! macro, moved sleep/yield_now to separate modules |
| src/sleep.rs | Extracted DurationSleep future and sleep function into dedicated module |
| src/yield_now.rs | Extracted YieldNow future and yield_now function into dedicated module |
| examples/simple.rs | Updated to use new stack-pinned task API with task! macro |
| examples/time.rs | Updated to use new stack-pinned task API and changed from static to local spawner |
| examples/yield.rs | Updated to use new stack-pinned task API with named task variables |
| README.md | Updated documentation to reflect no_alloc capability and simplified usage example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.