-
Notifications
You must be signed in to change notification settings - Fork 529
Dev mod api, 16 BIT I/O, PORTS, ASCII text display(32768 charachters or 64 charachters, 16 or 8Bit) #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…s and Splits arent working yet
sk337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that you that you should do one thing at a time as a modding API in already on the way (#459), and to make the reviewing process easier it common for pull requests to only add 1 large feature at a time. For example you would make 1 pull request for 16Bit IO/Ports, 1 for a ASCII test Display Etc. I would recommend to you to change this Pull request to be just for the 16Bit io.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i cant talk for SebLauge. but i would leave it to him to update the version of unity used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh right its just the version i was using i think i will reverse this when its at the end
I did create on for the 16 bit I/O but i kind of want to work on these together as some i want to make them work together for example the ports i know someone already made a version but i think i want to implement it with http servers and WebSocket server and have it also be able to send 16bit out. For the moding api i might merge it with this in the end idk |
|
Hey, I have already made a port implementation (#406 - not using http or websockets, because they're slow) built and published (updating to 2.1.6 as we speak) that was decided not to be part of the main project, so I don't see the need to make a completely new implementation and try to contribute to the project with them. And also, as stated earlier, a Modding API is already in the works (#459) I/O above 8-bit does sound like an interesting idea though! |
i was thinking http and WebSockets as they are easier to program a extension in python or something like that, and the moding api i am still thinking if i want to do it differently or merge that one. |
|
You understand that a pull request is not to show what you’re up to right? It’s for changes that everyone will receive.
|
|
I added the ports cause I wanted to implement them with 16 bit but mainly I'm probably going to work on the key and ascii displays |
|
Later I’ll make a quick pr w/ 16&32 bit IO |
The only issue is special charachters are just blank plus 128-255 is also blank
Only issue is special charachters are blank plus anything after 127 in decimal is also blank
There's already a PR for 16-bit IO. (and 32-bit IO at the same time)
There's already one of those. No need to add another. |
…s and Splits arent working yet
The only issue is special charachters are just blank plus 128-255 is also blank
My goal is to create a Mod API in a way that requires less work and has access to most of the functions in main code, while also adding ports which I want to do with http or WebSockets.
For Ascii text display have it be customizable for some characters not all.
also for key detector add more keys like delete, enter, and etc. Also make it possible for key combinations to also be made like ctrl + c might trigger something
Idea for Mod Api is to have some functions be sent during initialization so that the are registered with the other chips so basically when imported mod is ran it send the init function and the code runs that to init the chip, and the loop function is ran in a during rendering if that chip is running then the loop function is called