Skip to content

Conversation

@parshwa282011
Copy link

@parshwa282011 parshwa282011 commented May 6, 2025

My goal is to create a Mod API in a way that requires less work and has access to most of the functions in main code, while also adding ports which I want to do with http or WebSockets.

For Ascii text display have it be customizable for some characters not all.
also for key detector add more keys like delete, enter, and etc. Also make it possible for key combinations to also be made like ctrl + c might trigger something

Idea for Mod Api is to have some functions be sent during initialization so that the are registered with the other chips so basically when imported mod is ran it send the init function and the code runs that to init the chip, and the loop function is ran in a during rendering if that chip is running then the loop function is called

  • 16 Bit I/O
  • 16 Bit Mergers/Splitters
  • Displays use 8 Bit for color
  • Http server for input and output ports chips for 1-16bit ports
  • WebSocket server for input and output ports chips for 1-16bit ports
  • Ascii text display 8Bit
  • Ascii text display 16Bit
  • Key press detection made better
  • Mod Api

Copy link

@sk337 sk337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that you that you should do one thing at a time as a modding API in already on the way (#459), and to make the reviewing process easier it common for pull requests to only add 1 large feature at a time. For example you would make 1 pull request for 16Bit IO/Ports, 1 for a ASCII test Display Etc. I would recommend to you to change this Pull request to be just for the 16Bit io.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i cant talk for SebLauge. but i would leave it to him to update the version of unity used

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right its just the version i was using i think i will reverse this when its at the end

@parshwa282011
Copy link
Author

I believe that you that you should do one thing at a time as a modding API in already on the way (#459), and to make the reviewing process easier it common for pull requests to only add 1 large feature at a time. For example you would make 1 pull request for 16Bit IO/Ports, 1 for a ASCII test Display Etc. I would recommend to you to change this Pull request to be just for the 16Bit io.

I did create on for the 16 bit I/O but i kind of want to work on these together as some i want to make them work together for example the ports i know someone already made a version but i think i want to implement it with http servers and WebSocket server and have it also be able to send 16bit out. For the moding api i might merge it with this in the end idk

@squigglesdev
Copy link
Contributor

Hey, I have already made a port implementation (#406 - not using http or websockets, because they're slow) built and published (updating to 2.1.6 as we speak) that was decided not to be part of the main project, so I don't see the need to make a completely new implementation and try to contribute to the project with them.

And also, as stated earlier, a Modding API is already in the works (#459)

I/O above 8-bit does sound like an interesting idea though!

@parshwa282011
Copy link
Author

Hey, I have already made a port implementation (#406 - not using http or websockets, because they're slow) built and published (updating to 2.1.6 as we speak) that was decided not to be part of the main project, so I don't see the need to make a completely new implementation and try to contribute to the project with them.

And also, as stated earlier, a Modding API is already in the works (#459)

I/O above 8-bit does sound like an interesting idea though!

i was thinking http and WebSockets as they are easier to program a extension in python or something like that, and the moding api i am still thinking if i want to do it differently or merge that one.

@squigglesdev
Copy link
Contributor

squigglesdev commented May 6, 2025 via email

@parshwa282011
Copy link
Author

I added the ports cause I wanted to implement them with 16 bit but mainly I'm probably going to work on the key and ascii displays

@sk337
Copy link

sk337 commented May 6, 2025

Later I’ll make a quick pr w/ 16&32 bit IO

Parshwa and others added 2 commits May 7, 2025 07:02
The only issue is special charachters are just blank plus 128-255 is also blank
Only issue is special charachters are blank plus anything after 127 in decimal is also blank
@BraveCaperCat2
Copy link

I believe that you that you should do one thing at a time as a modding API in already on the way (#459), and to make the reviewing process easier it common for pull requests to only add 1 large feature at a time. For example you would make 1 pull request for 16Bit IO/Ports, 1 for a ASCII test Display Etc. I would recommend to you to change this Pull request to be just for the 16Bit io.

There's already a PR for 16-bit IO. (and 32-bit IO at the same time)

Later I’ll make a quick pr w/ 16&32 bit IO

There's already one of those. No need to add another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants