feat: improve buzzer with a speaker-like display #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
buzzers are already a bit of a power drain but i get the visual prefrence but it would need to be way more opimized before adding that |
Contributor
Author
|
The effect of displays on steps per second is negligible, especially on builtin chips like this. My steps per second has not changed basically at all with me adding this, so I'm not sure what you mean. |
Contributor
Author
|
All finished now and ready to merge. I've made some improvements to usage in subchips: |
|
this is such a cute tweak - I do hope he merges it. |
Contributor
Author
|
Me too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, me again.
Felt like the buzzer could do with a glow-up, as it has no visual feedback when beeping and booping.
So I gave it a display that oscillates with the frequency and amplitude of the input:
Always nice to have more visuals to look at in my opinion.
They are currently a bit buggy when used as displays in other chips, I'll work on that tomorrow.