Skip to content

Proposal: Adjusted navigation logic for irregular layouts (Dice Roll)#837

Closed
securesigner wants to merge 1 commit intoSeedSigner:devfrom
securesigner:fix/keyboard-navigation
Closed

Proposal: Adjusted navigation logic for irregular layouts (Dice Roll)#837
securesigner wants to merge 1 commit intoSeedSigner:devfrom
securesigner:fix/keyboard-navigation

Conversation

@securesigner
Copy link
Copy Markdown
Contributor

@securesigner securesigner commented Dec 11, 2025

This PR proposes an adjustment to the keyboard navigation behavior discussed in issue #555. Currently, on the "Dice Roll" screen, pressing "Down" from the "6" key wraps to the top of the screen because there is no key directly below it.

This change modifies get_key_below to scan leftward for the nearest available key when entering the last row (in this case, snapping to "DEL").

Note: I am aware this touches on the broader discussion in #555 regarding layout changes. This PR explores a logic-based solution to the navigation "dead zones" rather than a layout-based one, to see if it offers a smoother UX without requiring visual redesigns.

@securesigner securesigner changed the title Fix keyboard navigation on irregular layouts (fixes #555) Fix keyboard navigation on irregular layouts (Implements Issue #555) Dec 17, 2025
@newtonick
Copy link
Copy Markdown
Collaborator

tested and confirmed fix

@kdmukai
Copy link
Copy Markdown
Contributor

kdmukai commented Dec 19, 2025

I'm mostly a concept NACK.

This PR takes just one part of the discussion in #555 but disregards the rather in-depth nuance and blended solution discussed (modifying the key layout itself in many screens) which obviates the need for this change in most cases.

This remains a challenging screen even after that discussion.
SeedAddPassphraseView_symbols_2

A further minor annoyance: The behavior as it is currently implemented was intentional (and, again, thoroughly discussed in the Issue). It is grating to see this PR described as "fixes a navigation bug."

@securesigner securesigner changed the title Fix keyboard navigation on irregular layouts (Implements Issue #555) Proposal: Adjusted navigation logic for irregular layouts (Dice Roll) Dec 19, 2025
@securesigner securesigner closed this by deleting the head repository Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants