Proposal: Adjusted navigation logic for irregular layouts (Dice Roll)#837
Closed
securesigner wants to merge 1 commit intoSeedSigner:devfrom
Closed
Proposal: Adjusted navigation logic for irregular layouts (Dice Roll)#837securesigner wants to merge 1 commit intoSeedSigner:devfrom
securesigner wants to merge 1 commit intoSeedSigner:devfrom
Conversation
Collaborator
|
tested and confirmed fix |
Contributor
|
I'm mostly a concept NACK. This PR takes just one part of the discussion in #555 but disregards the rather in-depth nuance and blended solution discussed (modifying the key layout itself in many screens) which obviates the need for this change in most cases. This remains a challenging screen even after that discussion. A further minor annoyance: The behavior as it is currently implemented was intentional (and, again, thoroughly discussed in the Issue). It is grating to see this PR described as "fixes a navigation bug." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR proposes an adjustment to the keyboard navigation behavior discussed in issue #555. Currently, on the "Dice Roll" screen, pressing "Down" from the "6" key wraps to the top of the screen because there is no key directly below it.
This change modifies
get_key_belowto scan leftward for the nearest available key when entering the last row (in this case, snapping to "DEL").Note: I am aware this touches on the broader discussion in #555 regarding layout changes. This PR explores a logic-based solution to the navigation "dead zones" rather than a layout-based one, to see if it offers a smoother UX without requiring visual redesigns.