Skip to content

feat: Implement MicroSD Toast Timer configuration (Implements Issue #546)#838

Open
securesigner wants to merge 1 commit intoSeedSigner:devfrom
securesigner:feature/microsd-toast-timer
Open

feat: Implement MicroSD Toast Timer configuration (Implements Issue #546)#838
securesigner wants to merge 1 commit intoSeedSigner:devfrom
securesigner:feature/microsd-toast-timer

Conversation

@securesigner
Copy link
Contributor

This PR connects the existing 'MicroSD Toast Timer' setting to the toast notification logic, resolving #546.

Previously, the toast notification for SD card insertion/removal used a hardcoded 3-second duration regardless of the user setting.

Screenshots omitted as this is a behavior/timing change, not a visual UI change.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Documentation
  • Other

Checklist

  • I’ve run `pytest` and made sure all unit tests pass before submitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms/os:

Note: Verified functionality manually using a reproduction script to simulate hardware events."
--base dev

@securesigner securesigner changed the title feat: Implement MicroSD Toast Timer configuration (#546) feat: Implement MicroSD Toast Timer configuration (fixes #546) Dec 11, 2025
@securesigner securesigner changed the title feat: Implement MicroSD Toast Timer configuration (fixes #546) feat: Implement MicroSD Toast Timer configuration (Implements Issue #546) Dec 17, 2025
Copy link
Contributor

@Chaitanya-Keyal Chaitanya-Keyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK. Unless I am misinterpreting what this PR aims to do:

Issue #546 was already fully resolved by PR #600. That introduced the three MicroSD toast timer options (Disabled / 5 seconds / Until SD removed) and properly connected them to the boot-time RemoveSDCardToastManagerThread via the controller's startup logic:

if self.settings.get_value(SettingsConstants.SETTING__MICROSD_TOAST_TIMER) == SettingsConstants.MICROSD_TOAST_TIMER_FIVE_SECONDS:
self.activate_toast(RemoveSDCardToastManagerThread())
elif self.settings.get_value(SettingsConstants.SETTING__MICROSD_TOAST_TIMER) == SettingsConstants.MICROSD_TOAST_TIMER_FOREVER:
next_destination = Destination(RemoveMicroSDWarningView)

This PR modifies SDCardStateChangeToastManagerThread, which is an entirely different toast. That notification was never part of Issue #546's scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants