feat: Implement MicroSD Toast Timer configuration (Implements Issue #546)#838
Open
securesigner wants to merge 1 commit intoSeedSigner:devfrom
Open
feat: Implement MicroSD Toast Timer configuration (Implements Issue #546)#838securesigner wants to merge 1 commit intoSeedSigner:devfrom
securesigner wants to merge 1 commit intoSeedSigner:devfrom
Conversation
Contributor
Chaitanya-Keyal
left a comment
There was a problem hiding this comment.
NACK. Unless I am misinterpreting what this PR aims to do:
Issue #546 was already fully resolved by PR #600. That introduced the three MicroSD toast timer options (Disabled / 5 seconds / Until SD removed) and properly connected them to the boot-time RemoveSDCardToastManagerThread via the controller's startup logic:
seedsigner/src/seedsigner/controller.py
Lines 294 to 297 in bdcc7c2
This PR modifies SDCardStateChangeToastManagerThread, which is an entirely different toast. That notification was never part of Issue #546's scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR connects the existing 'MicroSD Toast Timer' setting to the toast notification logic, resolving #546.
Previously, the toast notification for SD card insertion/removal used a hardcoded 3-second duration regardless of the user setting.
Screenshots omitted as this is a behavior/timing change, not a visual UI change.
This pull request is categorized as a:
Checklist
If you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Verified functionality manually using a reproduction script to simulate hardware events."
--base dev