feat: Implement non-blocking long-press detection logic (Implements Issue #287)#839
feat: Implement non-blocking long-press detection logic (Implements Issue #287)#839securesigner wants to merge 3 commits intoSeedSigner:devfrom
Conversation
|
Reflecting on the discussion in #287: This PR provides the backend driver capability required to implement features like 'Long Press to Go Home' or 'Hold to Confirm'. It creates the KEY_PRESS_LONG event without forcing a specific UI implementation yet, solving the space constraint issues mentioned by @kdmukai by reusing existing buttons. |
|
I haven't reviewed the changes yet, but two quick thoughts:
|
This PR implements non-blocking logic to distinguish between short and long button presses in the hardware driver. This enhancement is needed for enabling new UI interactions (e.g., "Long Press for Home" or shortcuts) without disrupting the existing input loop.
The changes focus strictly on the
HardwareButtonslogic to enable the capability, as requested in Issue #287.Screenshots omitted as this is a backend hardware logic change with no visible UI modifications yet.
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before submitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.