Skip to content

test: Add regression test for Issue #550 (long message overflow)#841

Open
securesigner wants to merge 2 commits intoSeedSigner:devfrom
securesigner:fix/issue-550
Open

test: Add regression test for Issue #550 (long message overflow)#841
securesigner wants to merge 2 commits intoSeedSigner:devfrom
securesigner:fix/issue-550

Conversation

@securesigner
Copy link
Contributor

This PR addresses Issue #550: "TextDoesNotFitException when trying to sign very long messages".

It adds a regression test (tests/test_issue_550.py) that simulates passing a very long, uninterrupted string (such as a BOLT12 invoice) to the SeedSignMessageConfirmMessageScreen. This test ensures that the text reflow logic handles the overflow gracefully (using allow_text_overflow=True) instead of raising a TextDoesNotFitException and crashing the app.

The fix was confirmed to already be present in the codebase; this PR adds the test case to prevent future regressions.

Screenshots omitted as this PR only adds a backend test case and does not modify the visible UI.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Documentation
  • Other (Test coverage / Regression test)

Checklist

  • I’ve run pytest and made sure all unit tests pass before submitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms/os:

@kdmukai
Copy link
Contributor

kdmukai commented Dec 12, 2025

I think these sorts of issues will be rendered moot by #761

But IF that PR isn't merged, THEN this regression test might be good to have.

@securesigner
Copy link
Contributor Author

Thanks for the context. I see that #761 is still open and has conflicts, so I'll leave this regression test here as a safety net for the current codebase until that refactor lands. If #761 merges first, I'm happy to update or close this.

@kdmukai
Copy link
Contributor

kdmukai commented Dec 12, 2025

Yep, that totally makes sense. And good catch on my PR needing an update. I'll see if I can get that updated soon.

@kdmukai
Copy link
Contributor

kdmukai commented Dec 13, 2025

I've updated PR #761 to resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants