test: Add regression test for Issue #550 (long message overflow)#841
Open
securesigner wants to merge 2 commits intoSeedSigner:devfrom
Open
test: Add regression test for Issue #550 (long message overflow)#841securesigner wants to merge 2 commits intoSeedSigner:devfrom
securesigner wants to merge 2 commits intoSeedSigner:devfrom
Conversation
Contributor
|
I think these sorts of issues will be rendered moot by #761 But IF that PR isn't merged, THEN this regression test might be good to have. |
Contributor
Author
Contributor
|
Yep, that totally makes sense. And good catch on my PR needing an update. I'll see if I can get that updated soon. |
Contributor
|
I've updated PR #761 to resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #550: "TextDoesNotFitException when trying to sign very long messages".
It adds a regression test (
tests/test_issue_550.py) that simulates passing a very long, uninterrupted string (such as a BOLT12 invoice) to theSeedSignMessageConfirmMessageScreen. This test ensures that the text reflow logic handles the overflow gracefully (usingallow_text_overflow=True) instead of raising aTextDoesNotFitExceptionand crashing the app.The fix was confirmed to already be present in the codebase; this PR adds the test case to prevent future regressions.
Screenshots omitted as this PR only adds a backend test case and does not modify the visible UI.
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before submitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: