[Refactor] Seed XOR functionality in Seeds Menu, builds on PR #738 by berlinxray · Pull Request #885 · SeedSigner/seedsigner

berlinxray · 2026-03-02T04:37:02Z

Description

Based on PR #738 (seed-xor-flow) by https://github.com/Advaitgaur004
this applies conciseness improvements:

Remove RebuildSeedXORErrorView (redundant wrapper around ErrorView)
Remove trivial getters/setters in SeedStorage (use direct attribute access)
Merge validate/process controller methods into single process method
Simplify shard listing in ViewShards and RemoveShards views
Simplify discard-shards logic (reverse iteration, set-based lookup)
Remove dead code (unused imports, unreachable error branch, unused var)
Extract shared test vectors into seedxor_test_vectors.py
Trim verbose docstrings in SeedXORValidator

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

This pull request is categorized as a:

Code refactor

Checklist

I’ve run pytest and made sure all unit tests pass before submitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

Yes

I have tested this PR on the following platforms/os:

Raspberry Pi OS Manual Build
SeedSigner OS on a Pi0/Pi0W board

- View for loading a component key in the SeedXOR rebuild flow. - Current combined fingerprint of the SeedXOR components - View for selecting an existing seed to use as a SeedXOR component. - View for finalizing the SeedXOR seed.

…signer into seed-xor-flow

…edxor perfomed successfully.

This reverts commit 5430b35.

…dSigner#775

- put in src/seedsigner/helphers/mnemonic_generation.py - used in seed_views.py

…reated

…ct() in the init method

- fstring removed - text for xorcancelview changed a bit - errorview module added for seed_view.py

- Validation logic has been separated from the controller into a dedicated SeedXORValidator, and the controller's methods now consistently return None on success or an error dictionary on failure. Views are now responsible for handling these results and managing navigation.

…signer into seed-xor-flow

- Covers the `combine_mnemonics_with_xor` function and the `SeedXORValidator` class, ensuring correctness and robust error handling.

Based on PR SeedSigner#738 (seed-xor-flow), this applies conciseness improvements: - Remove RebuildSeedXORErrorView (redundant wrapper around ErrorView) - Remove trivial getters/setters in SeedStorage (use direct attribute access) - Merge validate/process controller methods into single process method - Simplify shard listing in ViewShards and RemoveShards views - Simplify discard-shards logic (reverse iteration, set-based lookup) - Remove dead code (unused imports, unreachable error branch, unused var) - Extract shared test vectors into seedxor_test_vectors.py - Trim verbose docstrings in SeedXORValidator Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Resolve merge conflicts to integrate upstream dev branch changes (i18n, settings cleanup, screen refactors) with the Seed XOR conciseness refactoring. Conflict resolutions: - controller.py: Keep PR's SeedXORValidator import (not needed in upstream) - mnemonic_generation.py: Keep PR's combine_mnemonics_with_xor and generate_mnemonic_from_image (new in PR, not in upstream) - settings_definition.py: Keep both PR's SEED_XOR and upstream's MICROSD_TOAST_TIMER settings - seed_views.py: Combine PR's LargeIconStatusScreen import with upstream's ButtonOptionWithoutTranslation and SpecterLegacyXPubQrEncoder - components.py: Uncomment CLOSE icon constant used by Seed XOR views Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Advaitgaur004 and others added 30 commits April 17, 2025 13:39

Implement Seed XOR functionality and update settings for feature access

10da8e7

Merge branch 'SeedSigner:dev' into seed-xor-flow

3afe98a

FLOW__SEEDXOR and method for processing seedxor component added

619861e

changed SeedXORSelectSeedView into SeedXORLoadComponentView

cc53925

added is_seedxor_component for SeedQRview.

2cb084d

SeedXOR rebuild flow views added including

c95e393

- View for loading a component key in the SeedXOR rebuild flow. - Current combined fingerprint of the SeedXOR components - View for selecting an existing seed to use as a SeedXOR component. - View for finalizing the SeedXOR seed.

Merge branch 'SeedSigner:dev' into seed-xor-flow

8b1a3b1

Merge branch 'seed-xor-flow' of https://github.com/Advaitgaur004/seed…

262fc35

…signer into seed-xor-flow

seedxor function removed from seed.py as it is irrelevant there.

31272be

rebuild_seedxor flow introduce which replace seedxor flow

a66590c

Rebuild SeedXOR View is added

dc79c19

minor refactor

ae430af

warning icon replace by LargeIconStatusScreen when finalization of se…

a7e8654

…edxor perfomed successfully.

Back Navigation from "Scan for Seed" (Load Shard Screen)

9c99c02

some ui fix

7b3fc29

More general approach for Back Navigation from "Scan for Seed"

5430b35

Revert "More general approach for Back Navigation from "Scan for Seed""

1daef47

This reverts commit 5430b35.

Using a general Approach for Back Navigation and target the issue See…

98cf8ee

…dSigner#775

[Minor-Fix] Naming changed to match PR SeedSigner#779

4ba11b2

seperate utility for combine_mnemonics_with_xor

7fe9b7b

- put in src/seedsigner/helphers/mnemonic_generation.py - used in seed_views.py

overview comment added

1969ff4

A dynamic error view that accepts all its content and navigation is c…

53b9e28

…reated

minor fix

2880e33

updated the RebuildSeedXORFinalizeOptionsView class to use set_redire…

5ecd024

…ct() in the init method

l10n concern resolved, now use format instead fstring for button data

a379a07

Single, clear message

8911eb5

minor fix

1e9e60b

- fstring removed - text for xorcancelview changed a bit - errorview module added for seed_view.py

first shard could be incorporated into the loop if combined_entropy

e94a7e7

Merge branch 'dev' into seed-xor-flow

959bf7e

Advaitgaur004 and others added 14 commits August 29, 2025 07:06

Merge branch 'seed-xor-flow' of https://github.com/Advaitgaur004/seed…

0047c86

…signer into seed-xor-flow

Broken Link fixed

d04ae70

Add unit tests for XOR logic and validation

750ab38

- Covers the `combine_mnemonics_with_xor` function and the `SeedXORValidator` class, ensuring correctness and robust error handling.

blank line style adopted

cf21aab

flow for seedxor is also added

9604579

minor fix

5970751

blank space - fixed

307cd05

Merge branch 'SeedSigner:dev' into seed-xor-flow

59563b0

Refactor: Standardize pending seed handling in RebuildSeedXOR

5542608

refactor(seedxor): Improve Seed XOR UI and localization

f49e11c

Relocate SeedXOR flow from Tools to Seeds

80bb123

Merge branch 'SeedSigner:dev' into seed-xor-flow

d41789d

minor fix in tools_views.py

c19c4b5

berlinxray changed the title ~~Seed xor flow concise~~ [refactor] Seed XOR functionality in Seeds Menu #738 Mar 2, 2026

berlinxray changed the title ~~[refactor] Seed XOR functionality in Seeds Menu #738~~ [Refactor] Seed XOR functionality in Seeds Menu #738 Mar 2, 2026

berlinxray changed the title ~~[Refactor] Seed XOR functionality in Seeds Menu #738~~ [Refactor] Seed XOR functionality in Seeds Menu, builds on PR #738 Mar 2, 2026

berlinxray force-pushed the seed-xor-flow-concise branch from feca192 to 196bba3 Compare March 3, 2026 22:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Refactor] Seed XOR functionality in Seeds Menu, builds on PR #738#885

[Refactor] Seed XOR functionality in Seeds Menu, builds on PR #738#885
berlinxray wants to merge 45 commits intoSeedSigner:devfrom
berlinxray:seed-xor-flow-concise

berlinxray commented Mar 2, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

berlinxray commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

berlinxray commented Mar 2, 2026 •

edited

Loading