Split out declarations and definitions into .h and .c#153
Open
Bengreen wants to merge 1 commit intoSegfault-Inc:masterfrom
Open
Split out declarations and definitions into .h and .c#153Bengreen wants to merge 1 commit intoSegfault-Inc:masterfrom
Bengreen wants to merge 1 commit intoSegfault-Inc:masterfrom
Conversation
…tic FWD declaration)
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current C code has some of the prototypes inside or at the beginning of the .c files.
I have found that this causes some errors where functions had their return types implicity assumed later to be found out that this was wrong resulting in a SEGV. This occurred when modifying the c code and not realising that you have to manually add prototypes for all functions you wish to use at the beginning of the source you are editing.
I have created .h files for all the .c files and moved all non-static prototypes into them.
This should make future editing of c code much easier.