[docs] ADR implementation updates - track by PR number, clarify PR body vs ADR, tracking status by issue#17697
Open
titusfortner wants to merge 11 commits into
Open
[docs] ADR implementation updates - track by PR number, clarify PR body vs ADR, tracking status by issue#17697titusfortner wants to merge 11 commits into
titusfortner wants to merge 11 commits into
Conversation
Contributor
PR Summary by QodoNumber ADRs by PR and move binding convergence to tracking issues Description
Diagram
High-Level Assessment
Files changed (3)
|
Contributor
Code Review by Qodo
Context used✅ Compliance rules (platform):
11 rules 1. ADR filename placeholder mismatch
|
Contributor
|
Code review by qodo was updated up to the latest commit 1f202c3 |
Contributor
|
Code review by qodo was updated up to the latest commit 533e2fb |
Contributor
|
Code review by qodo was updated up to the latest commit 18c53ab |
Contributor
|
Code review by qodo was updated up to the latest commit 3754bd8 |
Contributor
|
Code review by qodo was updated up to the latest commit cfc4db1 |
Contributor
|
Code review by qodo was updated up to the latest commit 532550c |
diemol
approved these changes
Jun 22, 2026
titusfortner
added a commit
to titusfortner/selenium
that referenced
this pull request
Jun 22, 2026
Proposes a public, static install on each binding's driver and service classes that downloads the driver and browser ahead of a session, warming the Selenium Manager cache without pinning paths or mutating options. Follows the ADR process refined in SeleniumHQ#17697. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
titusfortner
changed the title
pujagani
approved these changes
Jun 25, 2026
diemol
approved these changes
Jul 2, 2026
diemol
left a comment
diemol
left a comment
Member
There was a problem hiding this comment.
During the TLC meeting we decided we can merge this change.
p0deje
approved these changes
Jul 2, 2026
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+16
to
+17
| description: Link to the accepted record and its PR (the record number is the PR number). | ||
| placeholder: "docs/decisions/NNNN-title.md (#NNNN)" |
Contributor
There was a problem hiding this comment.
1. Adr filename placeholder mismatch 🐞 Bug ⚙ Maintainability
The ADR tracking issue template uses the placeholder docs/decisions/NNNN-title.md, which conflicts with the documented ADR naming convention NNNN-short-title.md and can lead to incorrect record paths/links being copied into tracking issues. The ADR template also repeats the NNNN-title.md placeholder in the Superseded-by hint, reinforcing the same wrong pattern.
Agent Prompt
### Issue description
The ADR process documentation standardizes record filenames as `NNNN-short-title.md`, where `NNNN` is the PR number. However, the newly added tracking issue template and the ADR markdown template still suggest `NNNN-title.md`, which can be copy/pasted into issues/records and produce incorrect paths/links.
### Issue Context
- The README defines the canonical filename format.
- The tracking issue template and the ADR template both provide filename placeholders that should match that canonical format.
### Fix Focus Areas
- .github/ISSUE_TEMPLATE/adr-tracking.yml[15-18]
- docs/decisions/0000-template.md[1-8]
- docs/decisions/README.md[40-46]
### Suggested change
- Update placeholders from `NNNN-title.md` to `NNNN-short-title.md` (or to a more explicit placeholder like `NNNN-your-short-title.md`) everywhere they appear in templates/comments, so they match the README’s convention.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Contributor
|
Code review by qodo was updated up to the latest commit c9d4efa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
Follow-up to #17665 (design decision record process).
💥 What does this PR do?
Refines the just-merged ADR process based on early experience writing records:
Accepted/Rejected/Superseded), so it stays immutable; the long-lived binding checklist lives in an issue. Adds an "ADR Implementation Tracking" issue form for it..github/PULL_REQUEST_TEMPLATE/adr.md) that points readers at the record and structures the body into related links, proposal notes, discussion, and tracking, documented in the README.Datefield from the template (git already tracks this).🔧 Implementation Notes
The scope and altitude wording directly answers recurring review feedback on draft ADRs: that records "bundle independently-adoptable decisions" and that they run implementation-heavy.
Tracking lives in a dedicated issue (linked from the record's PR) rather than the PR description, since the PR closes at merge while convergence continues for months.
🤖 AI assistance
💡 Additional Considerations
This is a process change to a just-merged TLC decision (#17665), so it should get TLC sign-off rather than a quiet merge.
🔄 Types of changes