Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion rust/src/firefox.rs
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,19 @@ impl SeleniumManager for FirefoxManager {
}

fn get_browser_names_in_path(&self) -> Vec<&str> {
vec![self.get_browser_name()]
let browser_version = self.get_browser_version();
let mut browser_names = vec![];
if self.is_beta(browser_version) {
browser_names.push("firefox-beta");
} else if self.is_dev(browser_version) {
browser_names.push("firefox-devedition");
} else if self.is_nightly(browser_version) {
browser_names.push("firefox-trunk");
} else if self.is_esr(browser_version) {
browser_names.push("firefox-esr");
}
browser_names.push(self.get_browser_name());
browser_names
Comment thread
bonigarcia marked this conversation as resolved.
Comment thread
bonigarcia marked this conversation as resolved.
Comment thread
bonigarcia marked this conversation as resolved.
Comment thread
bonigarcia marked this conversation as resolved.
}

fn get_http_client(&self) -> &Client {
Expand Down
3 changes: 3 additions & 0 deletions rust/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,9 @@ pub trait SeleniumManager {
discovered_major_browser_version,
));
download_browser = true;
if self.is_avoid_browser_download() {
self.set_browser_version(discovered_major_browser_version);
}
Comment thread
bonigarcia marked this conversation as resolved.
}
} else {
self.set_browser_version(discovered_version);
Expand Down
Loading