[java] Reject unescaped control characters in JSON strings#17740
Merged
Conversation
RFC 8259 §7 requires characters U+0000..U+001F to be escaped inside JSON strings. readString() previously appended them silently, so inputs containing a literal newline / tab / etc. inside quotes were accepted.
shs96c
force-pushed
the
shs-json-reject-control-chars
branch
from
857084c to
fec8010
Compare
Contributor
Qodo is busy workingCheck back in a few minutes. Qodo's code review agents are on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 8259 §7 requires characters U+0000..U+001F to be escaped inside JSON strings.
readString()previously appended them silently, so a literal newline / tab / etc. between quotes was accepted.We
readString()'s default branch we now throw aJsonExceptionwhen the character is below U+0020. Escapes (\n,\t,�, ...) continue to work.