-
Notifications
You must be signed in to change notification settings - Fork 134
Add Kimi K2.5 NVFP4 GB200 disaggregated TRT-LLM benchmarks via Dynamo #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
105dbb8
fd80f08
c385377
a4dfb8f
072a372
49f12bc
0ea91a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,8 +30,12 @@ elif [[ $FRAMEWORK == "dynamo-trt" ]]; then | |
| export MODEL_PATH="/mnt/numa1/groups/sa-shared/models/deepseek-r1-0528/" | ||
| export SERVED_MODEL_NAME="deepseek-r1-fp8" | ||
| export SRT_SLURM_MODEL_PREFIX="dsr1-fp8" | ||
| elif [[ $MODEL_PREFIX == "kimik2.5" && $PRECISION == "fp4" ]]; then | ||
| export MODEL_PATH="/mnt/lustre01/models/kimi-k2.5-nvfp4" | ||
| export SERVED_MODEL_NAME="kimi-k2.5-nvfp4" | ||
| export SRT_SLURM_MODEL_PREFIX="nvidia/Kimi-K2.5-NVFP4" | ||
| else | ||
| echo "Unsupported model prefix: $MODEL_PREFIX. Supported prefixes are: gptoss or dsr1" | ||
| echo "Unsupported model prefix: $MODEL_PREFIX. Supported prefixes are: gptoss, dsr1, or kimik2.5" | ||
| exit 1 | ||
| fi | ||
| elif [[ $FRAMEWORK == "dynamo-vllm" ]]; then | ||
|
|
@@ -124,6 +128,10 @@ if [[ $FRAMEWORK == "dynamo-vllm" ]]; then | |
| git clone https://github.com/NVIDIA/srt-slurm.git "$SRT_REPO_DIR" | ||
| cd "$SRT_REPO_DIR" | ||
| git checkout sa-submission-q2-2026 | ||
| elif [[ $FRAMEWORK == "dynamo-trt" && $MODEL_PREFIX == "kimik2.5" ]]; then | ||
| git clone https://github.com/NVIDIA/srt-slurm.git "$SRT_REPO_DIR" | ||
| cd "$SRT_REPO_DIR" | ||
| git checkout sa-submission-q2-2026 | ||
| else | ||
| git clone https://github.com/ishandhanani/srt-slurm.git "$SRT_REPO_DIR" | ||
| cd "$SRT_REPO_DIR" | ||
|
Comment on lines
128
to
137
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 The new Extended reasoning...What the bug is and how it manifests In The specific code path that triggers it Lines 128-134 of the modified file: if [[ $FRAMEWORK == "dynamo-vllm" ]]; then
git clone https://github.com/NVIDIA/srt-slurm.git "$SRT_REPO_DIR"
cd "$SRT_REPO_DIR"
git checkout sa-submission-q2-2026
elif [[ $FRAMEWORK == "dynamo-trt" && $MODEL_PREFIX == "kimik2.5" ]]; then
git clone https://github.com/NVIDIA/srt-slurm.git "$SRT_REPO_DIR"
cd "$SRT_REPO_DIR"
git checkout sa-submission-q2-2026There is no technical reason for two separate branches — they do exactly the same thing. Why existing code doesn't prevent it There is no deduplication mechanism in a shell script; the interpreter executes whatever branch matches. Nothing prevents the two arms from silently diverging if only one is updated in a future commit. What the impact would be The code is functionally correct today. The risk is future maintenance: when (not if) the How to fix it Merge the two arms into a single condition: if [[ $FRAMEWORK == "dynamo-vllm" || ($FRAMEWORK == "dynamo-trt" && $MODEL_PREFIX == "kimik2.5") ]]; then
git clone https://github.com/NVIDIA/srt-slurm.git "$SRT_REPO_DIR"
cd "$SRT_REPO_DIR"
git checkout sa-submission-q2-2026Step-by-step proof of the duplication
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have we already done this for kimi dynamo vllm submission? @nlevin-ui