Remove redundant code paths to use newer ConverTo/ConverToList APIs

Author: mythz

src/ServiceStack.OrmLite/Expressions/ReadExpressionCommandExtensions.cs

@@ -149,33 +149,6 @@ internal static List<T> LoadSelect<T>(this IDbCommand dbCmd, Expression<Func<T,
             var expr = dbCmd.GetDialectProvider().SqlExpression<T>().Where(predicate);
             return dbCmd.LoadListWithReferences<T, T>(expr);
         }
-
-        internal static T ExprConvertTo<T>(this IDataReader dataReader, IOrmLiteDialectProvider dialectProvider)
-        {
-            using (dataReader)
-            {
-                return dataReader.Read() ? dataReader.ConvertTo<T>(dialectProvider) : default(T);
-            }
-        }
-
-        internal static List<T> ExprConvertToList<T>(this IDataReader dataReader, IOrmLiteDialectProvider dialectProvider)
-        {
-            var fieldDefs = ModelDefinition<T>.Definition.AllFieldDefinitionsArray;
-
-            var to = new List<T>();
-            using (dataReader)
-            {
-               var indexCache = dataReader.GetIndexFieldsCache(ModelDefinition<T>.Definition);
-                while (dataReader.Read())
-                {
-                    var row = OrmLiteUtilExtensions.CreateInstance<T>();
-                    row.PopulateWithSqlReader(dialectProvider, dataReader, fieldDefs, indexCache);
-                    to.Add(row);
-                }
-            }
-            return to;
-        }
-
     }
 }
 

src/ServiceStack.OrmLite/OrmLiteResultsFilterExtensions.cs

@@ -95,7 +95,7 @@ internal static List<T> ExprConvertToList<T>(this IDbCommand dbCmd, string sql =
 
             using (var reader = dbCmd.ExecReader(dbCmd.CommandText))
             {
-                return reader.ExprConvertToList<T>(dbCmd.GetDialectProvider());
+                return reader.ConvertToList<T>(dbCmd.GetDialectProvider());
             }
         }
 
@@ -185,7 +185,7 @@ internal static T ExprConvertTo<T>(this IDbCommand dbCmd, string sql = null)
 
             using (var reader = dbCmd.ExecReader(dbCmd.CommandText))
             {
-                return reader.ExprConvertTo<T>(dbCmd.GetDialectProvider());
+                return reader.ConvertTo<T>(dbCmd.GetDialectProvider());
             }
         }